diff options
author | MCMXC <16797721+mcmxcdev@users.noreply.github.com> | 2023-07-29 21:12:16 -0600 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-07-30 08:42:16 +0530 |
commit | 32f76b74a69ad4d60a014bf075c39517888436bc (patch) | |
tree | 753378cc30f52d1e0e51be64b5a83d39f08f39c8 /src/stores/lib | |
parent | 6.4.1-nightly.15 [skip ci] (diff) | |
download | ferdium-app-32f76b74a69ad4d60a014bf075c39517888436bc.tar.gz ferdium-app-32f76b74a69ad4d60a014bf075c39517888436bc.tar.zst ferdium-app-32f76b74a69ad4d60a014bf075c39517888436bc.zip |
refactor: various improvements (#1296)
* refactor: various improvements
- enable no-use-before-define eslint rule
- shuffle code to conform to no-use-before-define eslint rule
- remove btoa dependency which is deprecated and replace with Buffer.from(string).toString('base64')
- convert some any types into useful ones
- add type annotations where possible
- remove unused @types/expect.js
- install @types/semver and ts-node which were missing
- repair and rewrite add-crowdin-contributors script
- remove export keyword from variables which are never consumed in another file
- remove unity indicator hack where linked issue was closed
- remove module declaration for kebab-case which is unused
- add missing state interface for certain components
- remove default exports for files which already have a named export
- export IRecipePreview so it can be used throughout codebase
- remove unused removeCacheForCallWith method from CachedRequest.ts
- cleanup unused colors and styles inside legacy theme
* - improve ColorPickerInput
- fix invalid DOM nesting with div inside p in EditSettingsForm
- fix progressbarAccentColor color picker not updating input when using slider
- install missing @types/react-color dependency
Diffstat (limited to 'src/stores/lib')
-rw-r--r-- | src/stores/lib/CachedRequest.ts | 6 | ||||
-rw-r--r-- | src/stores/lib/Request.ts | 1 |
2 files changed, 2 insertions, 5 deletions
diff --git a/src/stores/lib/CachedRequest.ts b/src/stores/lib/CachedRequest.ts index 25cc365e2..b24336fe6 100644 --- a/src/stores/lib/CachedRequest.ts +++ b/src/stores/lib/CachedRequest.ts | |||
@@ -1,5 +1,5 @@ | |||
1 | import { action } from 'mobx'; | 1 | import { action } from 'mobx'; |
2 | import { isEqual, remove } from 'lodash'; | 2 | import { isEqual } from 'lodash'; |
3 | import Request from './Request'; | 3 | import Request from './Request'; |
4 | 4 | ||
5 | export default class CachedRequest extends Request { | 5 | export default class CachedRequest extends Request { |
@@ -110,10 +110,6 @@ export default class CachedRequest extends Request { | |||
110 | }); | 110 | }); |
111 | } | 111 | } |
112 | 112 | ||
113 | removeCacheForCallWith(...args: any): void { | ||
114 | remove(this._apiCalls, c => isEqual(c.args, args)); | ||
115 | } | ||
116 | |||
117 | _addApiCall(args: any) { | 113 | _addApiCall(args: any) { |
118 | const newCall = { args, result: null }; | 114 | const newCall = { args, result: null }; |
119 | this._apiCalls.push(newCall); | 115 | this._apiCalls.push(newCall); |
diff --git a/src/stores/lib/Request.ts b/src/stores/lib/Request.ts index f9424ac99..911c5ccfb 100644 --- a/src/stores/lib/Request.ts +++ b/src/stores/lib/Request.ts | |||
@@ -1,6 +1,7 @@ | |||
1 | import { observable, action, computed, makeObservable } from 'mobx'; | 1 | import { observable, action, computed, makeObservable } from 'mobx'; |
2 | import { isEqual } from 'lodash/fp'; | 2 | import { isEqual } from 'lodash/fp'; |
3 | 3 | ||
4 | // eslint-disable-next-line no-use-before-define | ||
4 | type Hook = (request: Request) => void; | 5 | type Hook = (request: Request) => void; |
5 | 6 | ||
6 | export default class Request { | 7 | export default class Request { |