diff options
author | Mahadevan Sreenivasan <mahadevan_sv@yahoo.com> | 2020-06-15 15:04:34 +0000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-06-15 20:34:34 +0530 |
commit | ee8281730e0847530cb3c5db21bedb1301b6f7eb (patch) | |
tree | 5d8867748f2e7752702eebad0198b2537c6463b5 /src/models | |
parent | Update global user agent to conform with spec (#779) (diff) | |
download | ferdium-app-ee8281730e0847530cb3c5db21bedb1301b6f7eb.tar.gz ferdium-app-ee8281730e0847530cb3c5db21bedb1301b6f7eb.tar.zst ferdium-app-ee8281730e0847530cb3c5db21bedb1301b6f7eb.zip |
Open Documents inside Ferdi instead of external browser (#787)
* Bump version number
* no message
* Revert "no message"
This reverts commit 060f3084460d07e3b08394cd7703611f28095ea9.
* fix: Documents opened in Google drive should open inside Ferdi as a new BrowserWindow
- modify 'new-window' listener of service webview in Service.js to open links in external browser only when event.disposition != 'foreground-tab'. If event.disposition === 'foreground-tab' send an ipc-message to main to open the link inside Ferdi as a new Browser window
- Listen to 'open-browser-window' in index.js (main process) and check for event disposition
- create a child BrowserWindow with the main Ferdi window as parent
- Copy session information from the appropriate service (here google drive)
- Load the URL that was sent from the service renderer.
* Update src/index.js
refactor: Remove extra spaces in index.js
Co-authored-by: Sampath Kumar Krishnan <sampathBlam@users.noreply.github.com>
Co-authored-by: Amine Mouafik <amine@mouafik.fr>
Co-authored-by: vantezzen <hello@vantezzen.io>
Co-authored-by: Sampath Kumar Krishnan <sampathBlam@users.noreply.github.com>
Diffstat (limited to 'src/models')
-rw-r--r-- | src/models/Service.js | 17 |
1 files changed, 11 insertions, 6 deletions
diff --git a/src/models/Service.js b/src/models/Service.js index fb8a4298b..45dc55fce 100644 --- a/src/models/Service.js +++ b/src/models/Service.js | |||
@@ -266,12 +266,17 @@ export default class Service { | |||
266 | })); | 266 | })); |
267 | 267 | ||
268 | this.webview.addEventListener('new-window', (event, url, frameName, options) => { | 268 | this.webview.addEventListener('new-window', (event, url, frameName, options) => { |
269 | openWindow({ | 269 | debug('new-window', event, url, frameName, options); |
270 | event, | 270 | if (event.disposition === 'foreground-tab') { |
271 | url, | 271 | ipcRenderer.send('open-browser-window', event, this.id); |
272 | frameName, | 272 | } else { |
273 | options, | 273 | openWindow({ |
274 | }); | 274 | event, |
275 | url, | ||
276 | frameName, | ||
277 | options, | ||
278 | }); | ||
279 | } | ||
275 | }); | 280 | }); |
276 | 281 | ||
277 | 282 | ||