diff options
author | MCMXC <16797721+mcmxcdev@users.noreply.github.com> | 2023-07-23 20:08:52 -0600 |
---|---|---|
committer | Vijay Aravamudhan <vraravam@users.noreply.github.com> | 2023-07-25 07:45:23 +0000 |
commit | 8c131073730ec684145c2cc8ee8d6b39bbe9278d (patch) | |
tree | 1129d432ae88475909f0e5d38960395b75364902 /src/lib | |
parent | 6.4.1-nightly.11 [skip ci] (diff) | |
download | ferdium-app-8c131073730ec684145c2cc8ee8d6b39bbe9278d.tar.gz ferdium-app-8c131073730ec684145c2cc8ee8d6b39bbe9278d.tar.zst ferdium-app-8c131073730ec684145c2cc8ee8d6b39bbe9278d.zip |
chore: improve lint setup
- update eslint config
- merged eslint rules for JS and TS to avoid duplicates
- extended stricter lint ruleset from typescript-eslint
- corrected wrong setup for certain eslint rulesets
- opt in to reportUnusedDisableDirectives config option
- fix or disable a lot of lint issues throughout codebase
- remove trailingComma: all from prettier config which is default in prettier v3
- add volta configuration to package.json to autoload correct node and pnpm versions
- upgrade all eslint and prettier related dependencies to latest
- remove config options from settings.json which are default anyways
- remove config options from settings.json which are outdated/unknown
- set up prettier as default formatter in settings.json
Diffstat (limited to 'src/lib')
-rw-r--r-- | src/lib/Form.ts | 1 | ||||
-rw-r--r-- | src/lib/Menu.ts | 3 |
2 files changed, 4 insertions, 0 deletions
diff --git a/src/lib/Form.ts b/src/lib/Form.ts index ca96406e7..2b25eb193 100644 --- a/src/lib/Form.ts +++ b/src/lib/Form.ts | |||
@@ -3,6 +3,7 @@ import vjf from 'mobx-react-form/lib/validators/VJF'; | |||
3 | import { FormFields } from '../@types/mobx-form.types'; | 3 | import { FormFields } from '../@types/mobx-form.types'; |
4 | 4 | ||
5 | export default class DefaultForm extends Form { | 5 | export default class DefaultForm extends Form { |
6 | // eslint-disable-next-line @typescript-eslint/no-useless-constructor | ||
6 | constructor(fields: FormFields) { | 7 | constructor(fields: FormFields) { |
7 | super(fields); | 8 | super(fields); |
8 | } | 9 | } |
diff --git a/src/lib/Menu.ts b/src/lib/Menu.ts index d611d5f3e..f587f8df9 100644 --- a/src/lib/Menu.ts +++ b/src/lib/Menu.ts | |||
@@ -700,6 +700,7 @@ class FranzMenu implements StoresProps { | |||
700 | 700 | ||
701 | // Don't initialize when window['ferdium'] is undefined | 701 | // Don't initialize when window['ferdium'] is undefined |
702 | if (window['ferdium'] === undefined) { | 702 | if (window['ferdium'] === undefined) { |
703 | // eslint-disable-next-line no-console | ||
703 | console.log('skipping menu init'); | 704 | console.log('skipping menu init'); |
704 | return; | 705 | return; |
705 | } | 706 | } |
@@ -1010,6 +1011,7 @@ class FranzMenu implements StoresProps { | |||
1010 | }, | 1011 | }, |
1011 | ]; | 1012 | ]; |
1012 | 1013 | ||
1014 | // eslint-disable-next-line unicorn/prefer-at | ||
1013 | (tpl[tpl.length - 1].submenu as MenuItemConstructorOptions[]).push( | 1015 | (tpl[tpl.length - 1].submenu as MenuItemConstructorOptions[]).push( |
1014 | { | 1016 | { |
1015 | type: 'separator', | 1017 | type: 'separator', |
@@ -1027,6 +1029,7 @@ class FranzMenu implements StoresProps { | |||
1027 | 1029 | ||
1028 | tpl[5].submenu = this.todosMenu(); | 1030 | tpl[5].submenu = this.todosMenu(); |
1029 | 1031 | ||
1032 | // eslint-disable-next-line unicorn/prefer-at | ||
1030 | (tpl[tpl.length - 1].submenu as MenuItemConstructorOptions[]).push( | 1033 | (tpl[tpl.length - 1].submenu as MenuItemConstructorOptions[]).push( |
1031 | { | 1034 | { |
1032 | type: 'separator', | 1035 | type: 'separator', |