refactor: more lint improvements

- set parserOptions.ecmaVersion to latest and env to es2024 in eslint config
- install missing types libraries
- install eslint-plugin-sonar
- enable eslint-plugin-sonar recommended rules and declare jsx-runtime for react in eslint config
- clean up disabled lint rules which don't inflict problems anymore
- disable various lint issues and fix others

3 files changed, 4 insertions, 13 deletions

diff --git a/src/internal-server/app/Controllers/Http/ImageController.js b/src/internal-server/app/Controllers/Http/ImageController.js
index 5b8337c49..3ce6fb22d 100644
--- a/src/internal-server/app/Controllers/Http/ImageController.js
+++ b/src/internal-server/app/Controllers/Http/ImageController.js
@@ -1,6 +1,6 @@
 const Env = use('Env');
 
-const path = require('path');
+const path = require('node:path');
 const fs = require('fs-extra');
 const sanitize = require('sanitize-filename');
 
diff --git a/src/internal-server/app/Controllers/Http/UserController.js b/src/internal-server/app/Controllers/Http/UserController.js
index 43d925119..943d7705e 100644
--- a/src/internal-server/app/Controllers/Http/UserController.js
+++ b/src/internal-server/app/Controllers/Http/UserController.js
@@ -6,7 +6,7 @@ const { validateAll } = use('Validator');
 
 const fetch = require('node-fetch');
 const { v4: uuid } = require('uuid');
-const crypto = require('crypto');
+const crypto = require('node:crypto');
 const { DEFAULT_APP_SETTINGS } = require('../../../../config');
 const { convertToJSON } = require('../../../../jsUtils');
 const { API_VERSION } = require('../../../../environment-remote');
@@ -224,11 +224,7 @@ class UserController {
   }
 
   // Account import/export
-  async export({
-    // eslint-disable-next-line no-unused-vars
-    auth,
-    response,
-  }) {
+  async export({ _auth, response }) {
     const allServices = await Service.all();
     const services = allServices.toJSON();
     const allWorkspaces = await Workspace.all();
diff --git a/src/internal-server/app/Controllers/Http/WorkspaceController.js b/src/internal-server/app/Controllers/Http/WorkspaceController.js
index 352589567..d271dac12 100644
--- a/src/internal-server/app/Controllers/Http/WorkspaceController.js
+++ b/src/internal-server/app/Controllers/Http/WorkspaceController.js
@@ -92,12 +92,7 @@ class WorkspaceController {
     });
   }
 
-  async delete({
-    // eslint-disable-next-line no-unused-vars
-    request,
-    response,
-    params,
-  }) {
+  async delete({ response, params }) {
     // Validate user input
     const validation = await validateAll(params, {
       id: 'required',