refactor: various improvements (#1296)

* refactor: various improvements

- enable no-use-before-define eslint rule
- shuffle code to conform to no-use-before-define eslint rule
- remove btoa dependency which is deprecated and replace with Buffer.from(string).toString('base64')
- convert some any types into useful ones
- add type annotations where possible
- remove unused @types/expect.js
- install @types/semver and ts-node which were missing
- repair and rewrite add-crowdin-contributors script
- remove export keyword from variables which are never consumed in another file
- remove unity indicator hack where linked issue was closed
- remove module declaration for kebab-case which is unused
- add missing state interface for certain components
- remove default exports for files which already have a named export
- export IRecipePreview so it can be used throughout codebase
- remove unused removeCacheForCallWith method from CachedRequest.ts
- cleanup unused colors and styles inside legacy theme

* - improve ColorPickerInput
- fix invalid DOM nesting with div inside p in EditSettingsForm
- fix progressbarAccentColor color picker not updating input when using slider
- install missing @types/react-color dependency

1 files changed, 5 insertions, 12 deletions

diff --git a/src/index.ts b/src/index.ts
index 0487d692c..1c616b499 100644
--- a/src/index.ts
+++ b/src/index.ts
@@ -156,16 +156,6 @@ if (gotTheLock) {
   app.quit();
 }
 
-// Fix Unity indicator issue
-// https://github.com/electron/electron/issues/9046
-if (
-  isLinux &&
-  process.env.XDG_CURRENT_DESKTOP &&
-  ['Pantheon', 'Unity:Unity7'].includes(process.env.XDG_CURRENT_DESKTOP)
-) {
-  process.env.XDG_CURRENT_DESKTOP = 'Unity';
-}
-
 // Disable GPU acceleration
 if (
   !retrieveSettingValue(
@@ -674,8 +664,11 @@ ipcMain.handle('get-desktop-capturer-sources', () =>
 );
 
 ipcMain.on('window.toolbar-double-clicked', () => {
-  // eslint-disable-next-line @typescript-eslint/no-unused-expressions
-  mainWindow?.isMaximized() ? mainWindow.unmaximize() : mainWindow?.maximize();
+  if (mainWindow?.isMaximized()) {
+    mainWindow.unmaximize();
+  } else {
+    mainWindow?.maximize();
+  }
 });
 
 // Quit when all windows are closed.