diff options
| author |  Mahadevan Sreenivasan <mahadevan_sv@yahoo.com> | 2020-04-15 15:49:49 +0530 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2020-04-15 12:19:49 +0200 |
| commit | 24c6751d7618bd695ca24485b10e7e4d050b5c7b (patch) | |
| tree | ca88eb48272da668d4520dc1d8a8b165e76bd35d /src/features | |
| parent | Expose Dark Reader settings (#568) (diff) | |
| download | ferdium-app-24c6751d7618bd695ca24485b10e7e4d050b5c7b.tar.gz ferdium-app-24c6751d7618bd695ca24485b10e7e4d050b5c7b.tar.zst ferdium-app-24c6751d7618bd695ca24485b10e7e4d050b5c7b.zip | |
fix: Home button doesn't navigate to Service URL (#573)
* fix: Home button in service navigation bar doesn't navigate to Service Home
- Currently this doesnt happen because the reload method in ServiceStore simply reloads the chromium webview.
- Change .reload() to .goToIndex(0) where 0 is the absolute index in navigation history - Documentation can be found here - https://www.electronjs.org/docs/api/webview-tag#webviewgotoindexindex
* fix: Home button navigation
- Navigate to webiew.goToIndex(0) in WebControlsScreen instead of modifying ServicesStore based on @vantezzen's comments
Diffstat (limited to 'src/features')
| -rw-r--r-- | src/features/webControls/containers/WebControlsScreen.js | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/src/features/webControls/containers/WebControlsScreen.js b/src/features/webControls/containers/WebControlsScreen.js index 31168a397..258b15b14 100644 --- a/src/features/webControls/containers/WebControlsScreen.js +++ b/src/features/webControls/containers/WebControlsScreen.js | |||
| @@ -52,11 +52,8 @@ class WebControlsScreen extends Component { | |||
| 52 | } | 52 | } |
| 53 | 53 | ||
| 54 | goHome() { | 54 | goHome() { |
| 55 | const { reloadActive } = this.props.actions.service; | ||
| 56 | |||
| 57 | if (!this.webview) return; | 55 | if (!this.webview) return; |
| 58 | 56 | this.webview.goToIndex(0); | |
| 59 | reloadActive(); | ||
| 60 | } | 57 | } |
| 61 | 58 | ||
| 62 | reload() { | 59 | reload() { |