aboutsummaryrefslogtreecommitdiffstats
path: root/src/features
diff options
context:
space:
mode:
authorLibravatar Markandan R <rmarkandan@yahoo.com>2021-06-13 19:57:23 +0530
committerLibravatar GitHub <noreply@github.com>2021-06-13 19:57:23 +0530
commitd7b2ea8ce137afe0540307e59a3f13c658df8a0b (patch)
tree9980e9de0c0dd9bf97242061fff6f1163ad69dc0 /src/features
parentPass --publish never for PR builds (#1521) (diff)
downloadferdium-app-d7b2ea8ce137afe0540307e59a3f13c658df8a0b.tar.gz
ferdium-app-d7b2ea8ce137afe0540307e59a3f13c658df8a0b.tar.zst
ferdium-app-d7b2ea8ce137afe0540307e59a3f13c658df8a0b.zip
Removed the cyclical dependency in workspaces and announcement (Partial fix for: #1519) (#1522)
Diffstat (limited to 'src/features')
-rw-r--r--src/features/announcements/constants.js5
-rw-r--r--src/features/announcements/index.js3
-rw-r--r--src/features/announcements/store.js2
-rw-r--r--src/features/workspaces/constants.js6
-rw-r--r--src/features/workspaces/index.js8
-rw-r--r--src/features/workspaces/store.js2
6 files changed, 13 insertions, 13 deletions
diff --git a/src/features/announcements/constants.js b/src/features/announcements/constants.js
new file mode 100644
index 000000000..284226fdf
--- /dev/null
+++ b/src/features/announcements/constants.js
@@ -0,0 +1,5 @@
1export const ANNOUNCEMENTS_ROUTES = {
2 TARGET: '/announcements/:id',
3};
4
5export const GA_CATEGORY_ANNOUNCEMENTS = 'Announcements';
diff --git a/src/features/announcements/index.js b/src/features/announcements/index.js
index 10f081bb1..369ded1b2 100644
--- a/src/features/announcements/index.js
+++ b/src/features/announcements/index.js
@@ -7,9 +7,6 @@ export const GA_CATEGORY_ANNOUNCEMENTS = 'Announcements';
7 7
8export const announcementsStore = new AnnouncementsStore(); 8export const announcementsStore = new AnnouncementsStore();
9 9
10export const ANNOUNCEMENTS_ROUTES = {
11 TARGET: '/announcements/:id',
12};
13 10
14export default function initAnnouncements(stores, actions) { 11export default function initAnnouncements(stores, actions) {
15 const { features } = stores; 12 const { features } = stores;
diff --git a/src/features/announcements/store.js b/src/features/announcements/store.js
index 9ec5f67d2..4e465286a 100644
--- a/src/features/announcements/store.js
+++ b/src/features/announcements/store.js
@@ -7,7 +7,7 @@ import semver from 'semver';
7import localStorage from 'mobx-localstorage'; 7import localStorage from 'mobx-localstorage';
8 8
9import { FeatureStore } from '../utils/FeatureStore'; 9import { FeatureStore } from '../utils/FeatureStore';
10import { ANNOUNCEMENTS_ROUTES } from '.'; 10import { ANNOUNCEMENTS_ROUTES } from './constants';
11import { getAnnouncementRequest, getChangelogRequest, getCurrentVersionRequest } from './api'; 11import { getAnnouncementRequest, getChangelogRequest, getCurrentVersionRequest } from './api';
12import { announcementActions } from './actions'; 12import { announcementActions } from './actions';
13import { createActionBindings } from '../utils/ActionBinding'; 13import { createActionBindings } from '../utils/ActionBinding';
diff --git a/src/features/workspaces/constants.js b/src/features/workspaces/constants.js
new file mode 100644
index 000000000..413afa1e8
--- /dev/null
+++ b/src/features/workspaces/constants.js
@@ -0,0 +1,6 @@
1export const WORKSPACES_ROUTES = {
2 ROOT: '/settings/workspaces',
3 EDIT: '/settings/workspaces/:action/:id',
4};
5
6export const GA_CATEGORY_WORKSPACES = 'Workspaces';
diff --git a/src/features/workspaces/index.js b/src/features/workspaces/index.js
index 560b732ab..3db6de5b2 100644
--- a/src/features/workspaces/index.js
+++ b/src/features/workspaces/index.js
@@ -4,9 +4,6 @@ import { resetApiRequests } from './api';
4 4
5const debug = require('debug')('Ferdi:feature:workspaces'); 5const debug = require('debug')('Ferdi:feature:workspaces');
6 6
7export const GA_CATEGORY_WORKSPACES = 'Workspaces';
8export const DEFAULT_SETTING_KEEP_ALL_WORKSPACES_LOADED = false;
9
10export const workspaceStore = new WorkspacesStore(); 7export const workspaceStore = new WorkspacesStore();
11 8
12export default function initWorkspaces(stores, actions) { 9export default function initWorkspaces(stores, actions) {
@@ -31,8 +28,3 @@ export default function initWorkspaces(stores, actions) {
31 }, 28 },
32 ); 29 );
33} 30}
34
35export const WORKSPACES_ROUTES = {
36 ROOT: '/settings/workspaces',
37 EDIT: '/settings/workspaces/:action/:id',
38};
diff --git a/src/features/workspaces/store.js b/src/features/workspaces/store.js
index 5c90ff180..bddcb6eb4 100644
--- a/src/features/workspaces/store.js
+++ b/src/features/workspaces/store.js
@@ -13,7 +13,7 @@ import {
13 getUserWorkspacesRequest, 13 getUserWorkspacesRequest,
14 updateWorkspaceRequest, 14 updateWorkspaceRequest,
15} from './api'; 15} from './api';
16import { WORKSPACES_ROUTES } from './index'; 16import { WORKSPACES_ROUTES } from './constants';
17import { createReactions } from '../../stores/lib/Reaction'; 17import { createReactions } from '../../stores/lib/Reaction';
18import { createActionBindings } from '../utils/ActionBinding'; 18import { createActionBindings } from '../utils/ActionBinding';
19 19