diff options
author | Markus Hatvan <markus_hatvan@aon.at> | 2021-09-14 19:58:52 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-09-14 19:58:52 +0200 |
commit | 95df3522a15631abc51a4295cae0ea401a8d4e1e (patch) | |
tree | e5eb0f368c947683f01458e912f21756fb0d99cb /src/features/workspaces | |
parent | docs: add sad270 as a contributor for bug, userTesting [skip ci] (#1941) (diff) | |
download | ferdium-app-95df3522a15631abc51a4295cae0ea401a8d4e1e.tar.gz ferdium-app-95df3522a15631abc51a4295cae0ea401a8d4e1e.tar.zst ferdium-app-95df3522a15631abc51a4295cae0ea401a8d4e1e.zip |
feat: add eslint-plugin-unicorn (#1936)
Diffstat (limited to 'src/features/workspaces')
-rw-r--r-- | src/features/workspaces/components/EditWorkspaceForm.js | 2 | ||||
-rw-r--r-- | src/features/workspaces/components/WorkspaceDrawerItem.js | 2 | ||||
-rw-r--r-- | src/features/workspaces/models/Workspace.js | 2 | ||||
-rw-r--r-- | src/features/workspaces/store.js | 8 |
4 files changed, 7 insertions, 7 deletions
diff --git a/src/features/workspaces/components/EditWorkspaceForm.js b/src/features/workspaces/components/EditWorkspaceForm.js index cae95e9ed..f562733dd 100644 --- a/src/features/workspaces/components/EditWorkspaceForm.js +++ b/src/features/workspaces/components/EditWorkspaceForm.js | |||
@@ -108,7 +108,7 @@ class EditWorkspaceForm extends Component { | |||
108 | default: false, | 108 | default: false, |
109 | }, | 109 | }, |
110 | services: { | 110 | services: { |
111 | value: workspace.services.slice(), | 111 | value: [...workspace.services], |
112 | }, | 112 | }, |
113 | }, | 113 | }, |
114 | }); | 114 | }); |
diff --git a/src/features/workspaces/components/WorkspaceDrawerItem.js b/src/features/workspaces/components/WorkspaceDrawerItem.js index 82e1b81a4..7df2b60be 100644 --- a/src/features/workspaces/components/WorkspaceDrawerItem.js +++ b/src/features/workspaces/components/WorkspaceDrawerItem.js | |||
@@ -143,7 +143,7 @@ class WorkspaceDrawerItem extends Component { | |||
143 | isActive ? classes.activeServices : null, | 143 | isActive ? classes.activeServices : null, |
144 | ])} | 144 | ])} |
145 | > | 145 | > |
146 | {services.length | 146 | {services.length > 0 |
147 | ? services.join(', ') | 147 | ? services.join(', ') |
148 | : intl.formatMessage(messages.noServicesAddedYet)} | 148 | : intl.formatMessage(messages.noServicesAddedYet)} |
149 | </span> | 149 | </span> |
diff --git a/src/features/workspaces/models/Workspace.js b/src/features/workspaces/models/Workspace.js index d9488e991..14add9437 100644 --- a/src/features/workspaces/models/Workspace.js +++ b/src/features/workspaces/models/Workspace.js | |||
@@ -15,7 +15,7 @@ export default class Workspace { | |||
15 | 15 | ||
16 | constructor(data) { | 16 | constructor(data) { |
17 | if (!data.id) { | 17 | if (!data.id) { |
18 | throw Error('Workspace requires Id'); | 18 | throw new Error('Workspace requires Id'); |
19 | } | 19 | } |
20 | 20 | ||
21 | this.id = data.id; | 21 | this.id = data.id; |
diff --git a/src/features/workspaces/store.js b/src/features/workspaces/store.js index ec9d7ee7f..73e882990 100644 --- a/src/features/workspaces/store.js +++ b/src/features/workspaces/store.js | |||
@@ -302,8 +302,8 @@ export default class WorkspacesStore extends FeatureStore { | |||
302 | const { allServicesRequest } = services; | 302 | const { allServicesRequest } = services; |
303 | const servicesHaveBeenLoaded = allServicesRequest.wasExecuted && !allServicesRequest.isError; | 303 | const servicesHaveBeenLoaded = allServicesRequest.wasExecuted && !allServicesRequest.isError; |
304 | // Loop through all workspaces and remove invalid service ids (locally) | 304 | // Loop through all workspaces and remove invalid service ids (locally) |
305 | this.workspaces.forEach((workspace) => { | 305 | for (const workspace of this.workspaces) { |
306 | workspace.services.forEach((serviceId) => { | 306 | for (const serviceId of workspace.services) { |
307 | if ( | 307 | if ( |
308 | servicesHaveBeenLoaded | 308 | servicesHaveBeenLoaded |
309 | && !services.one(serviceId) | 309 | && !services.one(serviceId) |
@@ -311,7 +311,7 @@ export default class WorkspacesStore extends FeatureStore { | |||
311 | ) { | 311 | ) { |
312 | workspace.services.remove(serviceId); | 312 | workspace.services.remove(serviceId); |
313 | } | 313 | } |
314 | }); | 314 | } |
315 | }); | 315 | } |
316 | }; | 316 | }; |
317 | } | 317 | } |