Upgrade various dependencies to latest part 2 (#1557)

* Upgrade various dependencies to latest, remove unnecessary electron-hunspell
  - upgrade eslint and friends to latest
  - remove deprecated 'node-sass' in favor of 'sass'
  - disable new rules from 'eslint-config-airbnb' that are conflicting with current code style
  - add workspace config for 'vscode' that silences 'experimentalDecorator' warning and forces 'prettier' to single quote
* Run yarn lint to autofix with new ruleset and worked down lint issues to zero

1 files changed, 32 insertions, 15 deletions

diff --git a/src/features/workspaces/store.js b/src/features/workspaces/store.js
index bddcb6eb4..632f3c299 100644
--- a/src/features/workspaces/store.js
+++ b/src/features/workspaces/store.js
@@ -1,8 +1,4 @@
-import {
-  computed,
-  observable,
-  action,
-} from 'mobx';
+import { computed, observable, action } from 'mobx';
 import localStorage from 'mobx-localstorage';
 import { matchRoute } from '../../helpers/routing-helpers';
 import { workspaceActions } from './actions';
@@ -105,7 +101,10 @@ export default class WorkspacesStore extends FeatureStore {
       [workspaceActions.update, this._update],
       [workspaceActions.activate, this._setActiveWorkspace],
       [workspaceActions.deactivate, this._deactivateActiveWorkspace],
-      [workspaceActions.toggleKeepAllWorkspacesLoadedSetting, this._toggleKeepAllWorkspacesLoadedSetting],
+      [
+        workspaceActions.toggleKeepAllWorkspacesLoadedSetting,
+        this._toggleKeepAllWorkspacesLoadedSetting,
+      ],
     ]);
     this._allActions = this._freeUserActions.concat(this._premiumUserActions);
     this._registerActions(this._allActions);
@@ -124,7 +123,9 @@ export default class WorkspacesStore extends FeatureStore {
       this._activateLastUsedWorkspaceReaction,
       this._setWorkspaceBeingEditedReaction,
     ]);
-    this._allReactions = this._freeUserReactions.concat(this._premiumUserReactions);
+    this._allReactions = this._freeUserReactions.concat(
+      this._premiumUserReactions,
+    );
 
     this._registerReactions(this._allReactions);
 
@@ -157,12 +158,12 @@ export default class WorkspacesStore extends FeatureStore {
 
   getWorkspaceServices(workspace) {
     const { services } = this.stores;
-    return workspace.services.map(id => services.one(id)).filter(s => !!s);
+    return workspace.services.map((id) => services.one(id)).filter((s) => !!s);
   }
 
   // ========== PRIVATE METHODS ========= //
 
-  _getWorkspaceById = id => this.workspaces.find(w => w.id === id);
+  _getWorkspaceById = (id) => this.workspaces.find((w) => w.id === id);
 
   _updateSettings = (changes) => {
     localStorage.setItem('workspaces', {
@@ -178,6 +179,7 @@ export default class WorkspacesStore extends FeatureStore {
   };
 
   @action _create = async ({ name }) => {
+    // eslint-disable-next-line no-useless-catch
     try {
       const workspace = await createWorkspaceRequest.execute(name);
       await getUserWorkspacesRequest.result.push(workspace);
@@ -188,6 +190,7 @@ export default class WorkspacesStore extends FeatureStore {
   };
 
   @action _delete = async ({ workspace }) => {
+    // eslint-disable-next-line no-useless-catch
     try {
       await deleteWorkspaceRequest.execute(workspace);
       await getUserWorkspacesRequest.result.remove(workspace);
@@ -198,6 +201,7 @@ export default class WorkspacesStore extends FeatureStore {
   };
 
   @action _update = async ({ workspace }) => {
+    // eslint-disable-next-line no-useless-catch
     try {
       await updateWorkspaceRequest.execute(workspace);
       // Path local result optimistically
@@ -235,7 +239,9 @@ export default class WorkspacesStore extends FeatureStore {
       this.activeWorkspace = null;
     }, 100);
     // Indicate that we are done switching to the default workspace
-    setTimeout(() => { this.isSwitchingWorkspace = false; }, 1000);
+    setTimeout(() => {
+      this.isSwitchingWorkspace = false;
+    }, 1000);
   };
 
   @action _toggleWorkspaceDrawer = () => {
@@ -255,7 +261,9 @@ export default class WorkspacesStore extends FeatureStore {
   };
 
   _toggleKeepAllWorkspacesLoadedSetting = async () => {
-    this._updateSettings({ keepAllWorkspacesLoaded: !this.settings.keepAllWorkspacesLoaded });
+    this._updateSettings({
+      keepAllWorkspacesLoaded: !this.settings.keepAllWorkspacesLoaded,
+    });
   };
 
   // Reactions
@@ -309,7 +317,9 @@ export default class WorkspacesStore extends FeatureStore {
 
   _openDrawerWithSettingsReaction = () => {
     const { router } = this.stores;
-    const isWorkspaceSettingsRoute = router.location.pathname.includes(WORKSPACES_ROUTES.ROOT);
+    const isWorkspaceSettingsRoute = router.location.pathname.includes(
+      WORKSPACES_ROUTES.ROOT,
+    );
     const isSwitchingToSettingsRoute = !this.isSettingsRouteActive && isWorkspaceSettingsRoute;
     const isLeavingSettingsRoute = !isWorkspaceSettingsRoute && this.isSettingsRouteActive;
 
@@ -321,7 +331,10 @@ export default class WorkspacesStore extends FeatureStore {
       }
     } else if (isLeavingSettingsRoute) {
       this.isSettingsRouteActive = false;
-      if (!this._wasDrawerOpenBeforeSettingsRoute && this.isWorkspaceDrawerOpen) {
+      if (
+        !this._wasDrawerOpenBeforeSettingsRoute
+        && this.isWorkspaceDrawerOpen
+      ) {
         workspaceActions.toggleWorkspaceDrawer();
       }
     }
@@ -334,7 +347,11 @@ export default class WorkspacesStore extends FeatureStore {
     // Loop through all workspaces and remove invalid service ids (locally)
     this.workspaces.forEach((workspace) => {
       workspace.services.forEach((serviceId) => {
-        if (servicesHaveBeenLoaded && !services.one(serviceId) && serviceId !== KEEP_WS_LOADED_USID) {
+        if (
+          servicesHaveBeenLoaded
+          && !services.one(serviceId)
+          && serviceId !== KEEP_WS_LOADED_USID
+        ) {
           workspace.services.remove(serviceId);
         }
       });
@@ -351,5 +368,5 @@ export default class WorkspacesStore extends FeatureStore {
       this._startActions(this._premiumUserActions);
       this._startReactions(this._premiumUserReactions);
     }
-  }
+  };
 }