chore: change values inside mobx actions to fix console warnings (#532)

1 files changed, 14 insertions, 6 deletions

diff --git a/src/features/webControls/containers/WebControlsScreen.js b/src/features/webControls/containers/WebControlsScreen.jsx
index e5567eec5..25e14060d 100644
--- a/src/features/webControls/containers/WebControlsScreen.js
+++ b/src/features/webControls/containers/WebControlsScreen.jsx
@@ -2,7 +2,7 @@ import { Component } from 'react';
 import { observer, inject } from 'mobx-react';
 import PropTypes from 'prop-types';
 
-import { autorun, makeObservable, observable } from 'mobx';
+import { autorun, action, makeObservable, observable } from 'mobx';
 import WebControls from '../components/WebControls';
 import ServicesStore from '../../../stores/ServicesStore';
 import Service from '../../../models/Service';
@@ -27,6 +27,16 @@ class WebControlsScreen extends Component {
 
   autorunDisposer = null;
 
+  @action _setUrl(value) {
+    this.url = value;
+  }
+
+  @action _setUrlAndHistory(value) {
+    this._setUrl(value);
+    this.canGoBack = this.webview.canGoBack();
+    this.canGoForward = this.webview.canGoForward();
+  }
+
   constructor(props) {
     super(props);
 
@@ -39,15 +49,13 @@ class WebControlsScreen extends Component {
     this.autorunDisposer = autorun(() => {
       if (service.isAttached) {
         this.webview = service.webview;
-        this.url = this.webview.getURL();
+        this._setUrl(this.webview.getURL());
 
         for (const event of URL_EVENTS) {
           this.webview.addEventListener(event, e => {
             if (!e.isMainFrame) return;
 
-            this.url = e.url;
-            this.canGoBack = this.webview.canGoBack();
-            this.canGoForward = this.webview.canGoForward();
+            this._setUrlAndHistory(e.url);
           });
         }
       }
@@ -101,7 +109,7 @@ class WebControlsScreen extends Component {
     }
 
     this.webview.loadURL(url);
-    this.url = url;
+    this._setUrl(url);
   }
 
   openInBrowser() {