Refactoring: Url helpers (#1789)

These changes are mainly to ensure that 'shell.open*' invocations are only in a single file.
* Moved 'openPath' into the 'url-helpers' file.
* Extract 'openExternalUrl' into a common location in 'url-helpers'

This is done so that we can then apply vetting rules to ensure that there is no security concern as described in https://benjamin-altpeter.de/shell-openexternal-dangers/

1 files changed, 0 insertions, 7 deletions

diff --git a/src/environment.js b/src/environment.js
index 6332ad67b..f2a889be4 100644
--- a/src/environment.js
+++ b/src/environment.js
@@ -1,9 +1,7 @@
 import os from 'os';
 import { join } from 'path';
-import { ensureDirSync } from 'fs-extra';
 
 import { is, api as electronApi } from 'electron-util';
-import { shell } from 'electron';
 
 import { DEFAULT_ACCENT_COLOR } from '@meetfranz/theme';
 
@@ -65,11 +63,6 @@ export function asarRecipesPath(...segments) {
   return join(asarPath(join(__dirname, 'recipes')), ...([segments].flat()));
 }
 
-export async function openPath(folderName) {
-  ensureDirSync(folderName);
-  shell.openPath(folderName);
-}
-
 export const useLiveAPI = process.env.USE_LIVE_API;
 const useLocalAPI = process.env.USE_LOCAL_API;