refactor: general code improvements

- replace deprecated fs.exists with fs.existsSync
- replace console.log with debug
- replace hardcoded FERDI_VERSION in start.js with dynamic one from package.json
- correct JSDoc annotations in Handler.js
- simplify macOSPermissions.js
- updates to various eslint rules
- add FileReader to known globals

1 files changed, 11 insertions, 18 deletions

diff --git a/src/electron/macOSPermissions.js b/src/electron/macOSPermissions.js
index 940b16c6e..c114f4843 100644
--- a/src/electron/macOSPermissions.js
+++ b/src/electron/macOSPermissions.js
@@ -2,18 +2,15 @@ import { app, systemPreferences, dialog } from 'electron';
 import fs from 'fs';
 import macosVersion from 'macos-version';
 import path from 'path';
-import { isMac } from '../environment';
-
-let askForScreenCaptureAccess;
-if (isMac) {
-  // eslint-disable-next-line global-require
-  askForScreenCaptureAccess = require('node-mac-permissions').askForScreenCaptureAccess;
-}
+import { askForScreenCaptureAccess } from 'node-mac-permissions';
 
 const debug = require('debug')('Ferdi:macOSPermissions');
 
 const permissionExists = macosVersion.isGreaterThanOrEqualTo('10.15');
-const filePath = path.join(app.getPath('userData'), '.has-app-requested-screen-capture-permissions');
+const filePath = path.join(
+  app.getPath('userData'),
+  '.has-app-requested-screen-capture-permissions',
+);
 
 function hasPromptedForPermission() {
   if (!permissionExists) {
@@ -49,7 +46,7 @@ function createStatusFile() {
   }
 }
 
-export default async function (mainWindow) {
+export const askFormacOSPermissions = async mainWindow => {
   debug('Checking camera & microphone permissions');
   systemPreferences.askForMediaAccess('camera');
   systemPreferences.askForMediaAccess('microphone');
@@ -60,24 +57,20 @@ export default async function (mainWindow) {
     const { response } = await dialog.showMessageBox(mainWindow, {
       type: 'info',
       message: 'Enable Screen Sharing',
-      detail: 'To enable screen sharing for some services, Ferdi needs the permission to record your screen.',
-      buttons: [
-        'Allow screen sharing',
-        'No',
-        'Ask me later',
-      ],
+      detail:
+        'To enable screen sharing for some services, Ferdi needs the permission to record your screen.',
+      buttons: ['Allow screen sharing', 'No', 'Ask me later'],
       defaultId: 0,
       cancelId: 2,
     });
 
-    console.log('result', response);
     if (response === 0) {
       debug('Asking for access');
       askForScreenCaptureAccess();
       createStatusFile();
     } else if (response === 1) {
-      debug('Don\'t ask again');
+      debug("Don't ask again");
       createStatusFile();
     }
   }
-}
+};