diff options
author | MCMXC <16797721+mcmxcdev@users.noreply.github.com> | 2023-07-29 21:12:16 -0600 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-07-30 08:42:16 +0530 |
commit | 32f76b74a69ad4d60a014bf075c39517888436bc (patch) | |
tree | 753378cc30f52d1e0e51be64b5a83d39f08f39c8 /src/containers | |
parent | 6.4.1-nightly.15 [skip ci] (diff) | |
download | ferdium-app-32f76b74a69ad4d60a014bf075c39517888436bc.tar.gz ferdium-app-32f76b74a69ad4d60a014bf075c39517888436bc.tar.zst ferdium-app-32f76b74a69ad4d60a014bf075c39517888436bc.zip |
refactor: various improvements (#1296)
* refactor: various improvements
- enable no-use-before-define eslint rule
- shuffle code to conform to no-use-before-define eslint rule
- remove btoa dependency which is deprecated and replace with Buffer.from(string).toString('base64')
- convert some any types into useful ones
- add type annotations where possible
- remove unused @types/expect.js
- install @types/semver and ts-node which were missing
- repair and rewrite add-crowdin-contributors script
- remove export keyword from variables which are never consumed in another file
- remove unity indicator hack where linked issue was closed
- remove module declaration for kebab-case which is unused
- add missing state interface for certain components
- remove default exports for files which already have a named export
- export IRecipePreview so it can be used throughout codebase
- remove unused removeCacheForCallWith method from CachedRequest.ts
- cleanup unused colors and styles inside legacy theme
* - improve ColorPickerInput
- fix invalid DOM nesting with div inside p in EditSettingsForm
- fix progressbarAccentColor color picker not updating input when using slider
- install missing @types/react-color dependency
Diffstat (limited to 'src/containers')
-rw-r--r-- | src/containers/auth/AuthReleaseNotesScreen.tsx | 12 | ||||
-rw-r--r-- | src/containers/settings/EditSettingsScreen.tsx | 19 | ||||
-rw-r--r-- | src/containers/settings/EditUserScreen.tsx | 4 |
3 files changed, 23 insertions, 12 deletions
diff --git a/src/containers/auth/AuthReleaseNotesScreen.tsx b/src/containers/auth/AuthReleaseNotesScreen.tsx index c717529fa..c9d2286e1 100644 --- a/src/containers/auth/AuthReleaseNotesScreen.tsx +++ b/src/containers/auth/AuthReleaseNotesScreen.tsx | |||
@@ -1,7 +1,7 @@ | |||
1 | import { Component } from 'react'; | 1 | import { Component } from 'react'; |
2 | import { inject, observer } from 'mobx-react'; | 2 | import { inject, observer } from 'mobx-react'; |
3 | 3 | ||
4 | import { defineMessages, injectIntl } from 'react-intl'; | 4 | import { IntlShape, defineMessages, injectIntl } from 'react-intl'; |
5 | import Markdown from 'markdown-to-jsx'; | 5 | import Markdown from 'markdown-to-jsx'; |
6 | import { mdiArrowLeftCircle } from '@mdi/js'; | 6 | import { mdiArrowLeftCircle } from '@mdi/js'; |
7 | import { openExternalUrl } from '../../helpers/url-helpers'; | 7 | import { openExternalUrl } from '../../helpers/url-helpers'; |
@@ -20,14 +20,14 @@ const messages = defineMessages({ | |||
20 | }); | 20 | }); |
21 | 21 | ||
22 | interface IProps { | 22 | interface IProps { |
23 | intl: any; | 23 | intl: IntlShape; |
24 | } | 24 | } |
25 | 25 | ||
26 | class AuthReleaseNotesScreen extends Component<IProps> { | 26 | interface IState { |
27 | state = { | 27 | data: string; |
28 | data: '', | 28 | } |
29 | }; | ||
30 | 29 | ||
30 | class AuthReleaseNotesScreen extends Component<IProps, IState> { | ||
31 | constructor(props) { | 31 | constructor(props) { |
32 | super(props); | 32 | super(props); |
33 | 33 | ||
diff --git a/src/containers/settings/EditSettingsScreen.tsx b/src/containers/settings/EditSettingsScreen.tsx index 7cdff7fde..b9732ead0 100644 --- a/src/containers/settings/EditSettingsScreen.tsx +++ b/src/containers/settings/EditSettingsScreen.tsx | |||
@@ -319,12 +319,23 @@ const messages = defineMessages({ | |||
319 | 319 | ||
320 | interface EditSettingsScreenProps extends StoresProps, WrappedComponentProps {} | 320 | interface EditSettingsScreenProps extends StoresProps, WrappedComponentProps {} |
321 | 321 | ||
322 | interface EditSettingsScreenState { | ||
323 | lockedPassword: string; | ||
324 | } | ||
325 | |||
322 | @inject('stores', 'actions') | 326 | @inject('stores', 'actions') |
323 | @observer | 327 | @observer |
324 | class EditSettingsScreen extends Component<EditSettingsScreenProps> { | 328 | class EditSettingsScreen extends Component< |
325 | state = { | 329 | EditSettingsScreenProps, |
326 | lockedPassword: '', | 330 | EditSettingsScreenState |
327 | }; | 331 | > { |
332 | constructor(props) { | ||
333 | super(props); | ||
334 | |||
335 | this.state = { | ||
336 | lockedPassword: '', | ||
337 | }; | ||
338 | } | ||
328 | 339 | ||
329 | onSubmit(settingsData) { | 340 | onSubmit(settingsData) { |
330 | const { todos, workspaces } = this.props.stores; | 341 | const { todos, workspaces } = this.props.stores; |
diff --git a/src/containers/settings/EditUserScreen.tsx b/src/containers/settings/EditUserScreen.tsx index 10c308524..62df170fc 100644 --- a/src/containers/settings/EditUserScreen.tsx +++ b/src/containers/settings/EditUserScreen.tsx | |||
@@ -1,6 +1,6 @@ | |||
1 | import { Component, ReactElement } from 'react'; | 1 | import { Component, ReactElement } from 'react'; |
2 | import { inject, observer } from 'mobx-react'; | 2 | import { inject, observer } from 'mobx-react'; |
3 | import { defineMessages, injectIntl } from 'react-intl'; | 3 | import { IntlShape, defineMessages, injectIntl } from 'react-intl'; |
4 | 4 | ||
5 | import { StoresProps } from '../../@types/ferdium-components.types'; | 5 | import { StoresProps } from '../../@types/ferdium-components.types'; |
6 | import { FormFields } from '../../@types/mobx-form.types'; | 6 | import { FormFields } from '../../@types/mobx-form.types'; |
@@ -50,7 +50,7 @@ const messages = defineMessages({ | |||
50 | }); | 50 | }); |
51 | 51 | ||
52 | interface EditUserScreenProps extends StoresProps { | 52 | interface EditUserScreenProps extends StoresProps { |
53 | intl: any; | 53 | intl: IntlShape; |
54 | } | 54 | } |
55 | 55 | ||
56 | class EditUserScreen extends Component<EditUserScreenProps> { | 56 | class EditUserScreen extends Component<EditUserScreenProps> { |