Lazily compute cache size (#1404)

Computing the cache size can take a long time if the cache is large.
Previously, cache size computation was triggered by opening the Settings
pane, which slowed down changing settings even if the user wasn't
interested in the cache size.

This patch defers cache size computation until the Advanced tab is open
in the Setting page.

Additionally, cache size rendering (in MB / GB) is moved from the
AppStore into the EditSettingsForm to fix the notCleared functionality.

1 files changed, 1 insertions, 2 deletions

diff --git a/src/containers/settings/EditSettingsScreen.js b/src/containers/settings/EditSettingsScreen.js
index 94c53fc90..49ef03664 100644
--- a/src/containers/settings/EditSettingsScreen.js
+++ b/src/containers/settings/EditSettingsScreen.js
@@ -587,7 +587,6 @@ export default @inject('stores', 'actions') @observer class EditSettingsScreen e
     } = this.props.stores;
     const {
       updateStatus,
-      cacheSize,
       updateStatusTypes,
       isClearingAllCache,
       lockingFeatureEnabled,
@@ -610,7 +609,7 @@ export default @inject('stores', 'actions') @observer class EditSettingsScreen e
           noUpdateAvailable={updateStatus === updateStatusTypes.NOT_AVAILABLE}
           updateIsReadyToInstall={updateStatus === updateStatusTypes.DOWNLOADED}
           onSubmit={d => this.onSubmit(d)}
-          cacheSize={cacheSize}
+          getCacheSize={() => app.cacheSize}
           isClearingAllCache={isClearingAllCache}
           onClearAllCache={clearAllCache}
           isSpellcheckerIncludedInCurrentPlan={spellcheckerConfig.isIncludedInCurrentPlan}