Fix active Todos service behaviour (#1481)

* Return false instead of null in isTodosServiceAdded

* Resolve from TODOS_RECIPES_ID instead of hardcoded TODOS_RECIPE_ID

* Fix TodosWebview width toggling when isTodosServiceActive

* Add more todo service recipe IDs

* Refactor todos state management

* Moved todos service URL and recipe ID computation logic to todos/store
* Simplified TodosWebview by delegating to the store for the URL and
  removing the (unused) payment logic
* Made the todos service computation logic in the Service model depend
  on the logic in todos/store
* Made ServicesStore depend on the todos service logic from the Service
  model

* Todos appearance fixes

* Hide double horizontal rules if todo settings are hidden due to an
  added todo service
* Hide todos panel border when the panel is hidden or expanded
* Make expanded todos panel obey sidebar width and vertical style
  settings

* Make todos/store use isValidExternalURL

* Harden isValidExternalURL against malformed URLs

* Reduce todo URL string duplication in config.js

Co-authored-by: Kristóf Marussy <kristof@marussy.com>

1 files changed, 36 insertions, 11 deletions

diff --git a/src/config.js b/src/config.js
index 8930c755f..3a728b55e 100644
--- a/src/config.js
+++ b/src/config.js
@@ -62,19 +62,44 @@ export const SEARCH_ENGINE_URLS = {
   [SEARCH_ENGINE_DDG]: ({ searchTerm }) => `https://duckduckgo.com/?q=${searchTerm}`,
 };
 
+export const CUSTOM_TODO_SERVICE = 'isUsingCustomTodoService';
+
+const TODO_TODOIST_URL = 'https://todoist.com/app';
+const TODO_FRANZ_TODOS_URL = 'https://app.franztodos.com';
+const TODO_TICKTICK_URL = 'https://ticktick.com/signin';
+const TODO_MSTODO_URL = 'https://todo.microsoft.com/?app#';
+const TODO_HABITICA_URL = 'https://habitica.com/login';
+const TODO_NOZBE_URL = 'https://app.nozbe.com/#login';
+const TODO_RTM_URL = 'https://www.rememberthemilk.com/login/';
+const TODO_ANYDO_URL = 'https://desktop.any.do/';
+const TODO_GOOGLETASKS_URL = 'https://tasks.google.com/embed/?origin=https%3A%2F%2Fcalendar.google.com&fullWidth=1';
+
+export const TODO_SERVICE_RECIPE_IDS = {
+  [TODO_TODOIST_URL]: 'todoist',
+  [TODO_FRANZ_TODOS_URL]: 'franz-todos',
+  [TODO_TICKTICK_URL]: 'TickTick',
+  [TODO_MSTODO_URL]: 'mstodo',
+  [TODO_HABITICA_URL]: 'habitica',
+  [TODO_ANYDO_URL]: 'anydo',
+};
+
 export const TODO_APPS = {
-  'https://todoist.com/app': 'Todoist',
-  'https://app.franztodos.com': 'Franz Todo',
-  'https://ticktick.com/signin': 'TickTick',
-  'https://todo.microsoft.com/?app#': 'Microsoft To Do',
-  'https://habitica.com/login': 'Habitica',
-  'https://app.nozbe.com/#login': 'Nozbe',
-  'https://www.rememberthemilk.com/login/': 'Remember The Milk',
-  'https://desktop.any.do/': 'Any.do',
-  'https://tasks.google.com/embed/?origin=https%3A%2F%2Fcalendar.google.com&fullWidth=1': 'Google Tasks',
-  isUsingCustomTodoService: 'Other service',
+  [TODO_TODOIST_URL]: 'Todoist',
+  [TODO_FRANZ_TODOS_URL]: 'Franz Todo',
+  [TODO_TICKTICK_URL]: 'TickTick',
+  [TODO_MSTODO_URL]: 'Microsoft To Do',
+  [TODO_HABITICA_URL]: 'Habitica',
+  [TODO_NOZBE_URL]: 'Nozbe',
+  [TODO_RTM_URL]: 'Remember The Milk',
+  [TODO_ANYDO_URL]: 'Any.do',
+  [TODO_GOOGLETASKS_URL]: 'Google Tasks',
+  [CUSTOM_TODO_SERVICE]: 'Other service',
 };
 
+export const DEFAULT_TODO_SERVICE = TODO_FRANZ_TODOS_URL;
+export const DEFAULT_TODO_RECIPE_ID = TODO_SERVICE_RECIPE_IDS[DEFAULT_TODO_SERVICE];
+export const DEFAULT_TODO_SERVICE_NAME = TODO_APPS[DEFAULT_TODO_SERVICE];
+
 export const SIDEBAR_WIDTH = {
   35: 'Extremely slim sidebar',
   45: 'Very slim sidebar',
@@ -123,7 +148,7 @@ export const DEFAULT_APP_SETTINGS = {
 
   // Ferdi specific options
   server: LIVE_FERDI_API,
-  predefinedTodoServer: 'https://app.franztodos.com',
+  predefinedTodoServer: DEFAULT_TODO_SERVICE,
   autohideMenuBar: false,
   lockingFeatureEnabled: false,
   locked: false,