diff options
author | MCMXC <16797721+mcmxcdev@users.noreply.github.com> | 2024-04-18 08:18:36 -0600 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-04-18 08:18:36 -0600 |
commit | c49723056acec489765acb54bae3889ac07f25af (patch) | |
tree | 58bea705d61a728b060e615ce514b8d4a7936c9e /src/components/ui/select | |
parent | feat: hide all services workspace (#1713) (diff) | |
download | ferdium-app-c49723056acec489765acb54bae3889ac07f25af.tar.gz ferdium-app-c49723056acec489765acb54bae3889ac07f25af.tar.zst ferdium-app-c49723056acec489765acb54bae3889ac07f25af.zip |
refactor: bring down eslint warnings to zero (#1714)
- install `@eslint-react/eslint-plugin` dependency
- configure `@eslint-react/eslint-plugin` in eslint config
- modernize `lint` command in `package.json`
- disable or fix various reported lint issues
- fix `div` being nested in `p` for settings
- replace deprecated `event.keyCode` with `event.key`
- update isEscKeyPress method and unit tests which used deprecated `event.keyCode`
- allow `eslint` v8 as peer dependency for `@eslint-react/eslint-plugin`
Diffstat (limited to 'src/components/ui/select')
-rw-r--r-- | src/components/ui/select/index.tsx | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/components/ui/select/index.tsx b/src/components/ui/select/index.tsx index 2716ebc2d..397fd97ed 100644 --- a/src/components/ui/select/index.tsx +++ b/src/components/ui/select/index.tsx | |||
@@ -197,6 +197,7 @@ class SelectComponent extends Component<IProps, IState> { | |||
197 | this.arrowKeysHandler = this.arrowKeysHandler.bind(this); | 197 | this.arrowKeysHandler = this.arrowKeysHandler.bind(this); |
198 | } | 198 | } |
199 | 199 | ||
200 | // eslint-disable-next-line @eslint-react/no-unsafe-component-will-mount | ||
200 | UNSAFE_componentWillMount(): void { | 201 | UNSAFE_componentWillMount(): void { |
201 | const { value } = this.props; | 202 | const { value } = this.props; |
202 | 203 | ||
@@ -417,6 +418,7 @@ class SelectComponent extends Component<IProps, IState> { | |||
417 | ref={this.scrollContainerRef} | 418 | ref={this.scrollContainerRef} |
418 | > | 419 | > |
419 | {Object.keys(options!).map((key, i) => ( | 420 | {Object.keys(options!).map((key, i) => ( |
421 | // eslint-disable-next-line jsx-a11y/no-static-element-interactions | ||
420 | <div | 422 | <div |
421 | key={key} | 423 | key={key} |
422 | onClick={() => this.select(key)} | 424 | onClick={() => this.select(key)} |