feat: add eslint-plugin-unicorn (#1936)

3 files changed, 65 insertions, 47 deletions

diff --git a/src/api/apiBase.ts b/src/api/apiBase.ts
index dc10fad91..510ccb619 100644
--- a/src/api/apiBase.ts
+++ b/src/api/apiBase.ts
@@ -12,8 +12,6 @@ import {
 
 // Note: This cannot be used from the internal-server since we are not running within the context of a browser window
 const apiBase = (withVersion = true) => {
-  let url: string;
-
   if (
     !(window as any).ferdi ||
     !(window as any).ferdi.stores.settings ||
@@ -23,15 +21,12 @@ const apiBase = (withVersion = true) => {
     // Stores have not yet been loaded - return SERVER_NOT_LOADED to force a retry when stores are loaded
     return SERVER_NOT_LOADED;
   }
-  if ((window as any).ferdi.stores.settings.all.app.server === LOCAL_SERVER) {
-    // Use URL for local server
-    url = `http://${LOCAL_HOSTNAME}:${
-      (window as any).ferdi.stores.requests.localServerPort
-    }`;
-  } else {
-    // Load URL from store
-    url = (window as any).ferdi.stores.settings.all.app.server;
-  }
+  const url =
+    (window as any).ferdi.stores.settings.all.app.server === LOCAL_SERVER
+      ? `http://${LOCAL_HOSTNAME}:${
+          (window as any).ferdi.stores.requests.localServerPort
+        }`
+      : (window as any).ferdi.stores.settings.all.app.server;
 
   return withVersion ? `${url}/${API_VERSION}` : url;
 };
diff --git a/src/api/server/ServerApi.js b/src/api/server/ServerApi.js
index b5042525a..fb0495b19 100644
--- a/src/api/server/ServerApi.js
+++ b/src/api/server/ServerApi.js
@@ -1,6 +1,16 @@
+/* eslint-disable global-require */
 import { join } from 'path';
 import tar from 'tar';
-import { readdirSync, statSync, writeFileSync, copySync, ensureDirSync, pathExistsSync, readJsonSync, removeSync } from 'fs-extra';
+import {
+  readdirSync,
+  statSync,
+  writeFileSync,
+  copySync,
+  ensureDirSync,
+  pathExistsSync,
+  readJsonSync,
+  removeSync,
+} from 'fs-extra';
 import { require as remoteRequire } from '@electron/remote';
 
 import ServiceModel from '../../models/Service';
@@ -12,7 +22,14 @@ import UserModel from '../../models/User';
 import { sleep } from '../../helpers/async-helpers';
 
 import { SERVER_NOT_LOADED } from '../../config';
-import { osArch, osPlatform, asarRecipesPath, userDataRecipesPath, userDataPath, ferdiVersion } from '../../environment';
+import {
+  osArch,
+  osPlatform,
+  asarRecipesPath,
+  userDataRecipesPath,
+  userDataPath,
+  ferdiVersion,
+} from '../../environment';
 import apiBase from '../apiBase';
 import { prepareAuthRequest, sendAuthRequest } from '../utils/auth';
 
@@ -310,22 +327,22 @@ export default class ServerApi {
   // Recipes
   async getInstalledRecipes() {
     const recipesDirectory = getRecipeDirectory();
-    const paths = readdirSync(recipesDirectory)
-      .filter(
-        file =>
-          statSync(join(recipesDirectory, file)).isDirectory() &&
-          file !== 'temp' &&
-          file !== 'dev',
-      );
+    const paths = readdirSync(recipesDirectory).filter(
+      file =>
+        statSync(join(recipesDirectory, file)).isDirectory() &&
+        file !== 'temp' &&
+        file !== 'dev',
+    );
 
     this.recipes = paths
       .map(id => {
-        // eslint-disable-next-line
+        // eslint-disable-next-line import/no-dynamic-require
         const Recipe = require(id)(RecipeModel);
         return new Recipe(loadRecipeConfig(id));
       })
       .filter(recipe => recipe.id);
 
+    // eslint-disable-next-line unicorn/prefer-spread
     this.recipes = this.recipes.concat(this._getDevRecipes());
 
     debug('StubServerApi::getInstalledRecipes resolves', this.recipes);
@@ -425,8 +442,8 @@ export default class ServerApi {
       removeSync(join(recipesDirectory, recipeId, 'recipe.tar.gz'));
 
       return id;
-    } catch (err) {
-      console.error(err);
+    } catch (error) {
+      console.error(error);
 
       return false;
     }
@@ -434,7 +451,9 @@ export default class ServerApi {
 
   // News
   async getLatestNews() {
-    const url = `${apiBase(true)}/news?platform=${osPlatform}&arch=${osArch}&version=${ferdiVersion}`;
+    const url = `${apiBase(
+      true,
+    )}/news?platform=${osPlatform}&arch=${osArch}&version=${ferdiVersion}`;
     const request = await sendAuthRequest(url);
     if (!request.ok) throw request;
     const data = await request.json();
@@ -494,7 +513,7 @@ export default class ServerApi {
         debug('ServerApi::getLegacyServices resolves', services);
         return services;
       }
-    } catch (err) {
+    } catch {
       console.error('ServerApi::getLegacyServices no config found');
     }
 
@@ -523,8 +542,8 @@ export default class ServerApi {
       }
 
       return new ServiceModel(service, recipe);
-    } catch (e) {
-      debug(e);
+    } catch (error) {
+      debug(error);
       return null;
     }
   }
@@ -559,7 +578,7 @@ export default class ServerApi {
 
         return recipe;
       }),
-    ).catch(err => console.error("Can't load recipe", err));
+    ).catch(error => console.error("Can't load recipe", error));
   }
 
   _mapRecipePreviewModel(recipes) {
@@ -567,8 +586,8 @@ export default class ServerApi {
       .map(recipe => {
         try {
           return new RecipePreviewModel(recipe);
-        } catch (e) {
-          console.error(e);
+        } catch (error) {
+          console.error(error);
           return null;
         }
       })
@@ -580,8 +599,8 @@ export default class ServerApi {
       .map(newsItem => {
         try {
           return new NewsModel(newsItem);
-        } catch (e) {
-          console.error(e);
+        } catch (error) {
+          console.error(error);
           return null;
         }
       })
@@ -591,22 +610,21 @@ export default class ServerApi {
   _getDevRecipes() {
     const recipesDirectory = getDevRecipeDirectory();
     try {
-      const paths = readdirSync(recipesDirectory)
-        .filter(
-          file =>
-            statSync(join(recipesDirectory, file)).isDirectory() &&
-            file !== 'temp',
-        );
+      const paths = readdirSync(recipesDirectory).filter(
+        file =>
+          statSync(join(recipesDirectory, file)).isDirectory() &&
+          file !== 'temp',
+      );
 
       const recipes = paths
         .map(id => {
           let Recipe;
           try {
-            // eslint-disable-next-line
+            // eslint-disable-next-line import/no-dynamic-require
             Recipe = require(id)(RecipeModel);
             return new Recipe(loadRecipeConfig(id));
-          } catch (err) {
-            console.error(err);
+          } catch (error) {
+            console.error(error);
           }
 
           return false;
@@ -624,7 +642,7 @@ export default class ServerApi {
         });
 
       return recipes;
-    } catch (err) {
+    } catch {
       debug('Could not load dev recipes');
       return false;
     }
diff --git a/src/api/utils/auth.js b/src/api/utils/auth.js
index e493b2962..527c68840 100644
--- a/src/api/utils/auth.js
+++ b/src/api/utils/auth.js
@@ -1,7 +1,11 @@
 import localStorage from 'mobx-localstorage';
 import { ferdiLocale, ferdiVersion } from '../../environment';
 
-export const prepareAuthRequest = (options = { method: 'GET' }, auth = true) => {
+export const prepareAuthRequest = (
+  // eslint-disable-next-line unicorn/no-object-as-default-parameter
+  options = { method: 'GET' },
+  auth = true,
+) => {
   const request = Object.assign(options, {
     mode: 'cors',
     headers: {
@@ -16,12 +20,13 @@ export const prepareAuthRequest = (options = { method: 'GET' }, auth = true) =>
   });
 
   if (auth) {
-    request.headers.Authorization = `Bearer ${localStorage.getItem('authToken')}`;
+    request.headers.Authorization = `Bearer ${localStorage.getItem(
+      'authToken',
+    )}`;
   }
 
   return request;
 };
 
-export const sendAuthRequest = (url, options, auth) => (
-  window.fetch(url, prepareAuthRequest(options, auth))
-);
+export const sendAuthRequest = (url, options, auth) =>
+  window.fetch(url, prepareAuthRequest(options, auth));