Fix cache clearing not working in Windows 10 (#541) (#544)

* fix: Clear caches which is not working in Windows 10 (#541)
  - In AppStore, the partition directory of allorphanedserviceIds are attempted to be removed during clear cache. However, atleast in Windows, certain files like Cookies, indexedDB and other autogenerated ones during session creation are locked and hence fs.removeDirectory throws an exception. I have added a try catch around this piece of code to avoid uncaught exceptions which causes the spinner to spin indefnitely and prevents execution of further code
  - From electron docs - I found that calling session.clearstorage([options]) is a better way to clear session storage data. Hence, in LocalApi.js, we are clearing out all possible storages and quotas of all services and the default session. More info in this link - https://www.electronjs.org/docs/api/session#sesclearstoragedataoptions

* refactor: LocalApi
  - refactor clearAppCache and clearCache(serviceId) as suggested by @eandrogehlen

* refactor: #544
  - Remove clearAppCache from server/LocalApi.js to use clearCache for clearing both service and application sessions.

* fix: clear_cache
  - update function anme in AppStore.js to 'clearCache' instead of 'clearAppCache'. This got missed out during the refactor. Apologies.

2 files changed, 9 insertions, 12 deletions

diff --git a/src/api/LocalApi.js b/src/api/LocalApi.js
index e2a46874a..ccdedd3f5 100644
--- a/src/api/LocalApi.js
+++ b/src/api/LocalApi.js
@@ -16,7 +16,7 @@ export default class LocalApi {
     return this.local.getAppCacheSize();
   }
 
-  clearAppCache() {
-    return this.local.clearAppCache();
+  clearCache() {
+    return this.local.clearCache();
   }
 }
diff --git a/src/api/server/LocalApi.js b/src/api/server/LocalApi.js
index 2d9af416f..cc8035523 100644
--- a/src/api/server/LocalApi.js
+++ b/src/api/server/LocalApi.js
@@ -41,17 +41,14 @@ export default class LocalApi {
     });
   }
 
-  async clearCache(serviceId) {
-    const s = session.fromPartition(`persist:service-${serviceId}`);
+  async clearCache(serviceId = null) {
+    const s = serviceId ? session.fromPartition(`persist:service-${serviceId}`) : session.defaultSession;
 
-    debug('LocalApi::clearCache resolves', serviceId);
-    return s.clearCache();
-  }
-
-  async clearAppCache() {
-    const s = session.defaultSession;
-
-    debug('LocalApi::clearCache clearAppCache');
+    debug('LocalApi::clearCache resolves', (serviceId || 'clearAppCache'));
+    await s.clearStorageData({
+      storages: ['appcache', 'cookies', 'filesystem', 'indexdb', 'localstorage', 'shadercache', 'websql', 'serviceworkers', 'cachestorage'],
+      quotas: ['temporary', 'persistent', 'syncable'],
+    });
     return s.clearCache();
   }
 }