diff options
author | 2023-07-29 21:12:16 -0600 | |
---|---|---|
committer | 2023-07-30 08:42:16 +0530 | |
commit | 32f76b74a69ad4d60a014bf075c39517888436bc (patch) | |
tree | 753378cc30f52d1e0e51be64b5a83d39f08f39c8 /src/@types | |
parent | 6.4.1-nightly.15 [skip ci] (diff) | |
download | ferdium-app-32f76b74a69ad4d60a014bf075c39517888436bc.tar.gz ferdium-app-32f76b74a69ad4d60a014bf075c39517888436bc.tar.zst ferdium-app-32f76b74a69ad4d60a014bf075c39517888436bc.zip |
refactor: various improvements (#1296)
* refactor: various improvements
- enable no-use-before-define eslint rule
- shuffle code to conform to no-use-before-define eslint rule
- remove btoa dependency which is deprecated and replace with Buffer.from(string).toString('base64')
- convert some any types into useful ones
- add type annotations where possible
- remove unused @types/expect.js
- install @types/semver and ts-node which were missing
- repair and rewrite add-crowdin-contributors script
- remove export keyword from variables which are never consumed in another file
- remove unity indicator hack where linked issue was closed
- remove module declaration for kebab-case which is unused
- add missing state interface for certain components
- remove default exports for files which already have a named export
- export IRecipePreview so it can be used throughout codebase
- remove unused removeCacheForCallWith method from CachedRequest.ts
- cleanup unused colors and styles inside legacy theme
* - improve ColorPickerInput
- fix invalid DOM nesting with div inside p in EditSettingsForm
- fix progressbarAccentColor color picker not updating input when using slider
- install missing @types/react-color dependency
Diffstat (limited to 'src/@types')
-rw-r--r-- | src/@types/kebab-case.d.ts | 1 | ||||
-rw-r--r-- | src/@types/mobx-form.types.ts | 32 | ||||
-rw-r--r-- | src/@types/stores.types.ts | 9 |
3 files changed, 17 insertions, 25 deletions
diff --git a/src/@types/kebab-case.d.ts b/src/@types/kebab-case.d.ts deleted file mode 100644 index 712405ac0..000000000 --- a/src/@types/kebab-case.d.ts +++ /dev/null | |||
@@ -1 +0,0 @@ | |||
1 | declare module 'kebab-case'; | ||
diff --git a/src/@types/mobx-form.types.ts b/src/@types/mobx-form.types.ts index 07234a47a..aa274b9db 100644 --- a/src/@types/mobx-form.types.ts +++ b/src/@types/mobx-form.types.ts | |||
@@ -1,17 +1,17 @@ | |||
1 | import { File } from 'electron-dl'; | ||
2 | import { ChangeEventHandler, FocusEventHandler } from 'react'; | 1 | import { ChangeEventHandler, FocusEventHandler } from 'react'; |
3 | import { GlobalError } from './ferdium-components.types'; | 2 | import { GlobalError } from './ferdium-components.types'; |
4 | 3 | ||
5 | export interface FormFieldOptions { | 4 | interface SelectOptions { |
6 | value?: string; | ||
7 | label?: string; | ||
8 | disabled?: boolean; | 5 | disabled?: boolean; |
6 | label?: string; | ||
7 | value?: string; | ||
9 | } | 8 | } |
10 | 9 | ||
11 | export interface FormFields { | 10 | interface Listeners { |
12 | fields: { | 11 | onChange?: ChangeEventHandler<HTMLInputElement | HTMLSelectElement>; |
13 | [key: string]: Field; | 12 | onBlur?: FocusEventHandler<HTMLElement>; |
14 | }; | 13 | onFocus?: FocusEventHandler<HTMLElement>; |
14 | onDrop?: (file: File) => void; | ||
15 | } | 15 | } |
16 | 16 | ||
17 | export interface Field extends Listeners { | 17 | export interface Field extends Listeners { |
@@ -29,16 +29,8 @@ export interface Field extends Listeners { | |||
29 | set?: (value: any) => void; | 29 | set?: (value: any) => void; |
30 | [key: string]: any; | 30 | [key: string]: any; |
31 | } | 31 | } |
32 | 32 | export interface FormFields { | |
33 | export interface SelectOptions { | 33 | fields: { |
34 | disabled?: boolean; | 34 | [key: string]: Field; |
35 | label?: string; | 35 | }; |
36 | value?: string; | ||
37 | } | ||
38 | |||
39 | export interface Listeners { | ||
40 | onChange?: ChangeEventHandler<HTMLInputElement | HTMLSelectElement>; | ||
41 | onBlur?: FocusEventHandler<HTMLElement>; | ||
42 | onFocus?: FocusEventHandler<HTMLElement>; | ||
43 | onDrop?: (file: File) => void; | ||
44 | } | 36 | } |
diff --git a/src/@types/stores.types.ts b/src/@types/stores.types.ts index ff8f127ed..dc5da563f 100644 --- a/src/@types/stores.types.ts +++ b/src/@types/stores.types.ts | |||
@@ -1,3 +1,4 @@ | |||
1 | /* eslint-disable no-use-before-define */ | ||
1 | import Workspace from '../features/workspaces/models/Workspace'; | 2 | import Workspace from '../features/workspaces/models/Workspace'; |
2 | import Recipe from '../models/Recipe'; | 3 | import Recipe from '../models/Recipe'; |
3 | import Service from '../models/Service'; | 4 | import Service from '../models/Service'; |
@@ -201,7 +202,7 @@ interface RouterStore { | |||
201 | replace: () => void; | 202 | replace: () => void; |
202 | } | 203 | } |
203 | 204 | ||
204 | export interface ServicesStore extends TypedStore { | 205 | interface ServicesStore extends TypedStore { |
205 | clearCacheRequest: () => void; | 206 | clearCacheRequest: () => void; |
206 | createServiceRequest: CachedRequest; | 207 | createServiceRequest: CachedRequest; |
207 | deleteServiceRequest: () => void; | 208 | deleteServiceRequest: () => void; |
@@ -227,7 +228,7 @@ interface ISettings { | |||
227 | [key: string]: any; | 228 | [key: string]: any; |
228 | } | 229 | } |
229 | 230 | ||
230 | export interface SettingsStore extends TypedStore { | 231 | interface SettingsStore extends TypedStore { |
231 | update: (value: any) => void; | 232 | update: (value: any) => void; |
232 | remove: (value: any) => void; | 233 | remove: (value: any) => void; |
233 | fileSystemSettingsTypes: any[]; | 234 | fileSystemSettingsTypes: any[]; |
@@ -288,7 +289,7 @@ interface UIStore extends TypedStore { | |||
288 | theme: () => void; | 289 | theme: () => void; |
289 | } | 290 | } |
290 | 291 | ||
291 | export interface UserStore extends TypedStore { | 292 | interface UserStore extends TypedStore { |
292 | BASE_ROUTE: '/auth'; | 293 | BASE_ROUTE: '/auth'; |
293 | CHANGE_SERVER_ROUTE: '/auth/server'; | 294 | CHANGE_SERVER_ROUTE: '/auth/server'; |
294 | IMPORT_ROUTE: '/auth/signup/import'; | 295 | IMPORT_ROUTE: '/auth/signup/import'; |
@@ -338,7 +339,7 @@ export interface UserStore extends TypedStore { | |||
338 | team: () => void; | 339 | team: () => void; |
339 | } | 340 | } |
340 | 341 | ||
341 | export interface WorkspacesStore extends TypedStore { | 342 | interface WorkspacesStore extends TypedStore { |
342 | activeWorkspace: () => void; | 343 | activeWorkspace: () => void; |
343 | delete: ({ workspace }) => void; | 344 | delete: ({ workspace }) => void; |
344 | update: ({ workspace }) => void; | 345 | update: ({ workspace }) => void; |