refactor: various improvements (#1296)

* refactor: various improvements

- enable no-use-before-define eslint rule
- shuffle code to conform to no-use-before-define eslint rule
- remove btoa dependency which is deprecated and replace with Buffer.from(string).toString('base64')
- convert some any types into useful ones
- add type annotations where possible
- remove unused @types/expect.js
- install @types/semver and ts-node which were missing
- repair and rewrite add-crowdin-contributors script
- remove export keyword from variables which are never consumed in another file
- remove unity indicator hack where linked issue was closed
- remove module declaration for kebab-case which is unused
- add missing state interface for certain components
- remove default exports for files which already have a named export
- export IRecipePreview so it can be used throughout codebase
- remove unused removeCacheForCallWith method from CachedRequest.ts
- cleanup unused colors and styles inside legacy theme

* - improve ColorPickerInput
- fix invalid DOM nesting with div inside p in EditSettingsForm
- fix progressbarAccentColor color picker not updating input when using slider
- install missing @types/react-color dependency

1 files changed, 12 insertions, 20 deletions

diff --git a/src/@types/mobx-form.types.ts b/src/@types/mobx-form.types.ts
index 07234a47a..aa274b9db 100644
--- a/src/@types/mobx-form.types.ts
+++ b/src/@types/mobx-form.types.ts
@@ -1,17 +1,17 @@
-import { File } from 'electron-dl';
 import { ChangeEventHandler, FocusEventHandler } from 'react';
 import { GlobalError } from './ferdium-components.types';
 
-export interface FormFieldOptions {
-  value?: string;
-  label?: string;
+interface SelectOptions {
   disabled?: boolean;
+  label?: string;
+  value?: string;
 }
 
-export interface FormFields {
-  fields: {
-    [key: string]: Field;
-  };
+interface Listeners {
+  onChange?: ChangeEventHandler<HTMLInputElement | HTMLSelectElement>;
+  onBlur?: FocusEventHandler<HTMLElement>;
+  onFocus?: FocusEventHandler<HTMLElement>;
+  onDrop?: (file: File) => void;
 }
 
 export interface Field extends Listeners {
@@ -29,16 +29,8 @@ export interface Field extends Listeners {
   set?: (value: any) => void;
   [key: string]: any;
 }
-
-export interface SelectOptions {
-  disabled?: boolean;
-  label?: string;
-  value?: string;
-}
-
-export interface Listeners {
-  onChange?: ChangeEventHandler<HTMLInputElement | HTMLSelectElement>;
-  onBlur?: FocusEventHandler<HTMLElement>;
-  onFocus?: FocusEventHandler<HTMLElement>;
-  onDrop?: (file: File) => void;
+export interface FormFields {
+  fields: {
+    [key: string]: Field;
+  };
 }