feat: add eslint-plugin-unicorn (#1936)

2 files changed, 27 insertions, 21 deletions

diff --git a/scripts/build-theme-info.js b/scripts/build-theme-info.js
index 4058be942..8aee96ab7 100644
--- a/scripts/build-theme-info.js
+++ b/scripts/build-theme-info.js
@@ -23,7 +23,7 @@ async function getRulesFromCssFile(file) {
   const cssSrc = (await fs.readFile(file)).toString();
   const cssTree = css.parse(cssSrc);
 
-  return cssTree.stylesheet.rules;
+  return cssTree.stylesheet?.rules;
 }
 
 /**
@@ -49,25 +49,30 @@ async function getRulesFromCssFile(file) {
 function getSelectorsDeclaringValues(rules, values) {
   const output = {};
 
-  rules.forEach((rule) => {
+  for (const rule of rules) {
     if (rule.declarations) {
-      rule.declarations.forEach((declaration) => {
-        if (declaration.type === 'declaration'
-            && values.includes(declaration.value.toLowerCase())) {
+      for (const declaration of rule.declarations) {
+        if (
+          declaration.type === 'declaration' &&
+          values.includes(declaration.value.toLowerCase())
+        ) {
           if (!output[declaration.property]) {
             output[declaration.property] = [];
           }
-          output[declaration.property] = output[declaration.property].concat(rule.selectors);
+          // eslint-disable-next-line unicorn/prefer-spread
+          output[declaration.property] = output[declaration.property].concat(
+            rule.selectors,
+          );
         }
-      });
+      }
     }
-  });
+  }
 
   return output;
 }
 
 async function generateThemeInfo() {
-  if (!await fs.pathExists(cssFile)) {
+  if (!(await fs.pathExists(cssFile))) {
     console.log('Please make sure to build the project first.');
     return;
   }
@@ -75,23 +80,24 @@ async function generateThemeInfo() {
   // Read and parse css bundle
   const rules = await getRulesFromCssFile(cssFile);
 
-  console.log(`Found ${rules.length} rules`);
+  console.log(`Found ${rules?.length} rules`);
 
   // Get rules specifying the brand colors
   const brandRules = getSelectorsDeclaringValues(rules, accentColors);
 
-  console.log(`Found ${Object.keys(brandRules).join(', ')} properties that set color to brand color`);
+  console.log(
+    `Found ${Object.keys(brandRules).join(
+      ', ',
+    )} properties that set color to brand color`,
+  );
 
   // Join array of declarations into a single string
-  Object.keys(brandRules).forEach((rule) => {
+  for (const rule of Object.keys(brandRules)) {
     brandRules[rule] = brandRules[rule].join(', ');
-  });
+  }
 
   // Write object with theme info to file
-  fs.writeFile(
-    outputFile,
-    JSON.stringify(brandRules),
-  );
+  fs.writeFile(outputFile, JSON.stringify(brandRules));
 }
 
 generateThemeInfo();
diff --git a/scripts/link-readme.js b/scripts/link-readme.js
index 1e47cddf8..2ab38912c 100644
--- a/scripts/link-readme.js
+++ b/scripts/link-readme.js
@@ -22,7 +22,7 @@ let replacements = 0;
 // Regex matches strings that don't begin with a "[", i.e. are not already linked
 // followed by a "franz#" and digits to indicate
 // a GitHub issue, and not ending with a "]"
-readme = readme.replace(/(?<!\[)franz#\d{1,}(?![\]\d])/gi, (match) => {
+readme = readme.replace(/(?<!\[)franz#\d+(?![\d\]])/gi, match => {
   const issueNr = match.replace('franz#', '');
   replacements += 1;
   return `[franz#${issueNr}](https://github.com/meetfranz/franz/issues/${issueNr})`;
@@ -31,7 +31,7 @@ readme = readme.replace(/(?<!\[)franz#\d{1,}(?![\]\d])/gi, (match) => {
 // Replace external issues
 // Regex matches strings that don't begin with a "[", followed a repo name in the format "user/repo"
 // followed by a "#" and digits to indicate a GitHub issue, and not ending with a "]"
-readme = readme.replace(/(?<!\[)\w+\/\w+#\d{1,}(?![\]\d])/gi, (match) => {
+readme = readme.replace(/(?<!\[)\w+\/\w+#\d+(?![\d\]])/gi, match => {
   const issueNr = match.replace(/\D/g, '');
   const repo = match.replace(/#\d+/g, '');
   replacements += 1;
@@ -42,7 +42,7 @@ readme = readme.replace(/(?<!\[)\w+\/\w+#\d{1,}(?![\]\d])/gi, (match) => {
 // Regex matches strings that don't begin with a "[", i.e. are not already linked and
 // don't begin with "franz", i.e. are not Franz issues, followed by a "#" and digits to indicate
 // a GitHub issue, and not ending with a "]"
-readme = readme.replace(/(?<!\[|franz)#\d{1,}(?![\]\d])/gi, (match) => {
+readme = readme.replace(/(?<!\[|franz)#\d+(?![\d\]])/gi, match => {
   const issueNr = match.replace('#', '');
   replacements += 1;
   return `[#${issueNr}](https://github.com/getferdi/ferdi/issues/${issueNr})`;
@@ -51,7 +51,7 @@ readme = readme.replace(/(?<!\[|franz)#\d{1,}(?![\]\d])/gi, (match) => {
 // Link GitHub users
 // Regex matches strings that don't begin with a "[", i.e. are not already linked
 // followed by a "@" and at least one word character and not ending with a "]"
-readme = readme.replace(/(?<!\[)@\w+(?!\])/gi, (match) => {
+readme = readme.replace(/(?<!\[)@\w+(?!])/gi, match => {
   const username = match.replace('@', '');
   replacements += 1;
   return `[@${username}](https://github.com/${username})`;