Bring in missing python (system dependency) (#1639)

* Introduce python as a system dependency (needed by node-gyp to compile native modules)
* Introduce node-pre-gyp as a dependency
* Upgrade sqlite3 to 5.1.7 to test the above

Note: Currently this still depends on the availability of prebuilt binaries from the prebuild library. Which means that once a new version is available, only then will we know if this python/node-gyp integration works or whether it will still fallback to the availability of the prebuilt binaries from external sources. Only time will tell if we have solved the issue or not.

2 files changed, 13 insertions, 8 deletions

diff --git a/scripts/build-unix.sh b/scripts/build-unix.sh
index 04aa9e70f..f485f9087 100755
--- a/scripts/build-unix.sh
+++ b/scripts/build-unix.sh
@@ -3,7 +3,7 @@
 # INTRO:
 # This file is used to build ferdium on both x64 and arm-based for macos and linux (not tested on arm for linux).
 # It also handles any corrupted node modules with the 'CLEAN' env var (set it to 'true' for cleaning)
-# It will install the system dependencies except for node (which is still verified)
+# It will install the system dependencies except for node and python (which are still verified)
 # I sometimes symlink my 'recipes' folder so that any changes that I need to do in it can also be committed and pushed independently
 # This file can live anywhere in your PATH
 
@@ -32,6 +32,7 @@ command_exists() {
 #                  Checking the developer environment
 # Check for installed programmes
 command_exists node || fail_with_docs "Node is not installed"
+command_exists python || fail_with_docs "python is not installed"
 
 # Check node version
 EXPECTED_NODE_VERSION=$(cat .nvmrc)
@@ -42,6 +43,15 @@ if [ "v$EXPECTED_NODE_VERSION" != "$ACTUAL_NODE_VERSION" ]; then
     actual  : [$ACTUAL_NODE_VERSION]"
 fi
 
+# Check python version
+EXPECTED_PYTHON_VERSION=$(node -p 'require("./package.json").engines.python')
+ACTUAL_PYTHON_VERSION=$(python --version | sed -e "s/Python //")
+if [[ "$ACTUAL_PYTHON_VERSION" != "$EXPECTED_PYTHON_VERSION" ]]; then
+  fail_with_docs "You are not running the expected version of Python!
+    expected: [$EXPECTED_PYTHON_VERSION]
+    actual  : [$ACTUAL_PYTHON_VERSION]"
+fi
+
 # Check if the 'recipes' folder is present either as a git submodule or a symbolic link
 if ! [ -f "recipes/package.json" ]; then
   fail_with_docs "'recipes' folder is missing or submodule has not been checked out"
@@ -68,7 +78,7 @@ else
   fi
 
   npm cache clean --force
-  rm -rf ~/.npm ~/.electron-gyp ~/.asdf/installs/nodejs/*/.npm/
+  rm -rf ~/.npm ~/.electron-gyp
 
   git -C recipes clean -fxd # Clean recipes folder/submodule
   git clean -fxd            # Note: This will blast away the 'recipes' folder if you have symlinked it
@@ -79,8 +89,6 @@ fi
 
 # -----------------------------------------------------------------------------
 # Ensure that the system dependencies are at the correct version - recover if not
-# If 'asdf' is installed, reshim for new nodejs if necessary
-command_exists asdf && asdf reshim nodejs
 
 # Ensure that the system dependencies are at the correct version
 # Check pnpm version
@@ -99,9 +107,6 @@ if [[ "$EXPECTED_PNPM_VERSION" != "$EXPECTED_RECIPES_PNPM_VERSION" ]]; then
     actual               : [$EXPECTED_PNPM_VERSION]"
 fi
 
-# If 'asdf' is installed, reshim for new nodejs if necessary
-command_exists asdf && asdf reshim nodejs
-
 # -----------------------------------------------------------------------------
 printf "\n*************** Building recipes ***************\n"
 pushd recipes
diff --git a/scripts/build-windows.ps1 b/scripts/build-windows.ps1
index 5da7df540..02289d172 100644
--- a/scripts/build-windows.ps1
+++ b/scripts/build-windows.ps1
@@ -1,7 +1,7 @@
 # INTRO:
 # This file is used to build ferdium on windows.
 # It also handles any corrupted node modules with the 'CLEAN' env var (set it to 'true' for cleaning)
-# It will install the system dependencies except for node (which is still verified)
+# It will install the system dependencies except for node and python (which are still verified)
 # I sometimes symlink my 'recipes' folder so that any changes that I need to do in it can also be committed and pushed independently
 # This file can live anywhere in your PATH