feat: default download path as a user preference (#1746)

6 files changed, 129 insertions, 37 deletions

diff --git a/src/components/settings/settings/EditSettingsForm.tsx b/src/components/settings/settings/EditSettingsForm.tsx
index c3e8d46a0..2900aa2af 100644
--- a/src/components/settings/settings/EditSettingsForm.tsx
+++ b/src/components/settings/settings/EditSettingsForm.tsx
@@ -1,5 +1,6 @@
 import { systemPreferences } from '@electron/remote';
 import { mdiGithub, mdiOpenInNew, mdiPowerPlug } from '@mdi/js';
+import { ipcRenderer } from 'electron';
 import { noop } from 'lodash';
 import { observer } from 'mobx-react';
 import prettyBytes from 'pretty-bytes';
@@ -191,6 +192,14 @@ const messages = defineMessages({
     id: 'settings.app.subheadlineCache',
     defaultMessage: 'Cache',
   },
+  subheadlineUserAgent: {
+    id: 'settings.app.subheadlineUserAgent',
+    defaultMessage: 'User Agent',
+  },
+  subheadlineDownloads: {
+    id: 'settings.app.subheadlineDownloads',
+    defaultMessage: 'Downloads',
+  },
   cacheInfo: {
     id: 'settings.app.cacheInfo',
     defaultMessage: 'Ferdium cache is currently using {size} of disk space.',
@@ -281,6 +290,10 @@ const messages = defineMessages({
     id: 'settings.app.buttonOpenFerdiumCertsFolder',
     defaultMessage: 'Open certificates folder',
   },
+  buttonOpenFolderSelector: {
+    id: 'settings.app.buttonOpenFolderSelector',
+    defaultMessage: 'Open folder selector',
+  },
 });
 
 const Hr = (): ReactElement => (
@@ -1034,49 +1047,87 @@ class EditSettingsForm extends Component<IProps, IState> {
 
                 <Hr />
 
-                <Input
-                  placeholder="User Agent"
-                  onChange={e => this.submit(e)}
-                  {...form.$('userAgentPref').bind()}
-                />
-                <p className="settings__help">
-                  {intl.formatMessage(globalMessages.userAgentHelp)}
-                </p>
-                <p className="settings__help">
-                  {intl.formatMessage(messages.appRestartRequired)}
-                </p>
+                <div className="settings__settings-group">
+                  <H3>{intl.formatMessage(messages.subheadlineDownloads)}</H3>
+
+                  <Input
+                    placeholder="Default download folder"
+                    onChange={e => {
+                      this.submit(e);
+                    }}
+                    {...form.$('downloadFolderPath').bind()}
+                  />
+
+                  <Button
+                    buttonType="secondary"
+                    label={intl.formatMessage(
+                      messages.buttonOpenFolderSelector,
+                    )}
+                    className="settings__open-settings-cache-button"
+                    onClick={e => {
+                      ipcRenderer
+                        .invoke('download-folder-select')
+                        .then(path => {
+                          if (path) {
+                            form.$('downloadFolderPath').set(path);
+                            this.submit(e);
+                          }
+                        })
+                        .catch(console.error);
+                    }}
+                    disabled={isClearingAllCache}
+                    loaded={!isClearingAllCache}
+                  />
+                </div>
 
                 <Hr />
 
                 <div className="settings__settings-group">
-                  <H3>{intl.formatMessage(messages.subheadlineCache)}</H3>
-                  <p>
-                    {intl.formatMessage(messages.cacheInfo, {
-                      size: cacheSize,
-                    })}
+                  <Input
+                    placeholder="User Agent"
+                    onChange={e => this.submit(e)}
+                    {...form.$('userAgentPref').bind()}
+                  />
+
+                  <p className="settings__help">
+                    {intl.formatMessage(globalMessages.userAgentHelp)}
                   </p>
-                  {notCleared && (
-                    <p>{intl.formatMessage(messages.cacheNotCleared)}</p>
-                  )}
+                  <p className="settings__help">
+                    {intl.formatMessage(messages.appRestartRequired)}
+                  </p>
+
+                  <Hr />
+
                   <div className="settings__settings-group">
-                    <div className="settings__open-settings-cache-container">
-                      <Button
-                        buttonType="secondary"
-                        label={intl.formatMessage(globalMessages.clearCache)}
-                        className="settings__open-settings-cache-button"
-                        onClick={() => {
-                          onClearAllCache();
-                          this.onClearCacheClicked();
-                        }}
-                        disabled={isClearingAllCache}
-                        loaded={!isClearingAllCache}
-                      />
-                      <Button
-                        buttonType="secondary"
-                        label="Open Process Manager"
-                        className="settings__open-settings-cache-button"
-                        onClick={openProcessManager}
-                      />
+                    <H3>{intl.formatMessage(messages.subheadlineCache)}</H3>
+                    <p>
+                      {intl.formatMessage(messages.cacheInfo, {
+                        size: cacheSize,
+                      })}
+                    </p>
+                    {notCleared && (
+                      <p>{intl.formatMessage(messages.cacheNotCleared)}</p>
+                    )}
+                    <div className="settings__settings-group">
+                      <div className="settings__open-settings-cache-container">
+                        <Button
+                          buttonType="secondary"
+                          label={intl.formatMessage(globalMessages.clearCache)}
+                          className="settings__open-settings-cache-button"
+                          onClick={() => {
+                            onClearAllCache();
+                            this.onClearCacheClicked();
+                          }}
+                          disabled={isClearingAllCache}
+                          loaded={!isClearingAllCache}
+                        />
+                        <Button
+                          buttonType="secondary"
+                          label="Open Process Manager"
+                          className="settings__open-settings-cache-button"
+                          onClick={openProcessManager}
+                        />
+                      </div>
                     </div>
                   </div>
                 </div>
diff --git a/src/config.ts b/src/config.ts
index 348b4b85d..0034b00a6 100644
--- a/src/config.ts
+++ b/src/config.ts
@@ -401,6 +401,7 @@ export const DEFAULT_APP_SETTINGS = {
   automaticUpdates: true,
   universalDarkMode: true,
   userAgentPref: '',
+  downloadFolderPath: '',
   adaptableDarkMode: true,
   accentColor: DEFAULT_ACCENT_COLOR,
   progressbarAccentColor: DEFAULT_ACCENT_COLOR,
diff --git a/src/containers/settings/EditSettingsScreen.tsx b/src/containers/settings/EditSettingsScreen.tsx
index fdd9bd8bc..a596e53a3 100644
--- a/src/containers/settings/EditSettingsScreen.tsx
+++ b/src/containers/settings/EditSettingsScreen.tsx
@@ -341,6 +341,11 @@ const messages = defineMessages({
     id: 'settings.app.form.keepAllWorkspacesLoaded',
     defaultMessage: 'Keep all workspaces loaded',
   },
+  downloadFolderPath: {
+    id: 'settings.app.form.downloadFolderPath',
+    defaultMessage:
+      'Default download folder (leave blank to be prompted for each download)',
+  },
 });
 
 interface EditSettingsScreenProps extends StoresProps, WrappedComponentProps {}
@@ -430,6 +435,7 @@ class EditSettingsScreen extends Component<
         scheduledDNDStart: settingsData.scheduledDNDStart,
         scheduledDNDEnd: settingsData.scheduledDNDEnd,
         enableGPUAcceleration: Boolean(settingsData.enableGPUAcceleration),
+        downloadFolderPath: String(settingsData.downloadFolderPath),
         enableGlobalHideShortcut: Boolean(
           settingsData.enableGlobalHideShortcut,
         ),
@@ -982,6 +988,14 @@ class EditSettingsScreen extends Component<
           default: DEFAULT_APP_SETTINGS.userAgentPref,
           placeholder: defaultUserAgent(),
         },
+        downloadFolderPath: {
+          label: intl.formatMessage(messages.downloadFolderPath),
+          value: ifUndefined<string>(
+            settings.all.app.downloadFolderPath,
+            DEFAULT_APP_SETTINGS.downloadFolderPath,
+          ),
+          default: DEFAULT_APP_SETTINGS.userAgentPref,
+        },
         darkMode: {
           label: intl.formatMessage(messages.darkMode),
           value: ifUndefined<boolean>(
diff --git a/src/electron/ipc-api/download.ts b/src/electron/ipc-api/download.ts
index d749cb889..a306ba68d 100644
--- a/src/electron/ipc-api/download.ts
+++ b/src/electron/ipc-api/download.ts
@@ -52,4 +52,14 @@ export default (params: { mainWindow: BrowserWindow }) => {
       }
     },
   );
+
+  ipcMain.handle('download-folder-select', async () => {
+    const result = await dialog.showOpenDialog(params.mainWindow, {
+      properties: ['openDirectory'],
+    });
+
+    if (result.canceled) return null;
+
+    return result.filePaths[0];
+  });
 };
diff --git a/src/i18n/locales/en-US.json b/src/i18n/locales/en-US.json
index 3947b2e5f..a91a58725 100644
--- a/src/i18n/locales/en-US.json
+++ b/src/i18n/locales/en-US.json
@@ -194,6 +194,7 @@
   "settings.app.buttonOpenFerdiumCertsFolder": "Open certificates folder",
   "settings.app.buttonOpenFerdiumProfileFolder": "Open Profile folder",
   "settings.app.buttonOpenFerdiumServiceRecipesFolder": "Open Service Recipes folder",
+  "settings.app.buttonOpenFolderSelector": "Open folder selector",
   "settings.app.buttonOpenImportExport": "Import / Export",
   "settings.app.buttonSearchForUpdate": "Check for updates",
   "settings.app.buttonShowChangelog": "Show changelog",
@@ -213,6 +214,7 @@
   "settings.app.form.confirmOnQuit": "Confirm when quitting Ferdium",
   "settings.app.form.customTodoServer": "Custom Todo Server",
   "settings.app.form.darkMode": "Enable Dark Mode",
+  "settings.app.form.downloadFolderPath": "Default download folder (leave blank to be prompted for each download)",
   "settings.app.form.enableGPUAcceleration": "Enable GPU Acceleration",
   "settings.app.form.enableGlobalHideShortcut": "Enable Global shortcut to hide Ferdium",
   "settings.app.form.enableLock": "Enable Password Lock",
@@ -308,7 +310,9 @@
   "settings.app.servicesUpdateStatusUpToDate": "Your services are up-to-date",
   "settings.app.spellCheckerLanguageInfo": "Ferdium uses your Mac's built-in spellchecker to check for typos. If you want to change the languages the spellchecker checks for, you can do so in your Mac's System Preferences.",
   "settings.app.subheadlineCache": "Cache",
+  "settings.app.subheadlineDownloads": "Downloads",
   "settings.app.subheadlineFerdiumProfile": "Ferdium Profile",
+  "settings.app.subheadlineUserAgent": "User Agent",
   "settings.app.todoServerInfo": "This server will be used for the \"Ferdium Todo\" feature.",
   "settings.app.translationHelp": "Help us to translate Ferdium into your language.",
   "settings.app.universalDarkModeInfo": "Universal Dark Mode tries to dynamically generate dark mode styles for services that are otherwise not currently supported.",
diff --git a/src/index.ts b/src/index.ts
index cccf0ef66..09e411e13 100644
--- a/src/index.ts
+++ b/src/index.ts
@@ -245,6 +245,18 @@ const createWindow = () => {
         openExternalUrl(url);
         return { action: 'deny' };
       });
+
+      // Handle will download event from main process (prevent download dialog)
+      contents.session.on('will-download', (_e, item) => {
+        const downloadFolderPath = retrieveSettingValue(
+          'downloadFolderPath',
+          DEFAULT_APP_SETTINGS.downloadFolderPath,
+        ) as string;
+
+        if (downloadFolderPath !== '') {
+          item.setSavePath(join(downloadFolderPath, item.getFilename()));
+        }
+      });
     }
   });