refactor: removed legacy properties from recipes

(Addendum to getferdi/recipes#605)

5 files changed, 3 insertions, 24 deletions

diff --git a/package-lock.json b/package-lock.json
index bafb70961..6739d0e52 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -7306,14 +7306,6 @@
       "integrity": "sha1-anmQQ3ynNtXhKI25K9MmbV9csqo=",
       "dev": true
     },
-    "address-rfc2822": {
-      "version": "2.1.0",
-      "resolved": "https://registry.npmjs.org/address-rfc2822/-/address-rfc2822-2.1.0.tgz",
-      "integrity": "sha512-TwoTmJcYzS+CLw/h+AO3zOzRFGSMNowmp/tlOXcYPygkr2vMAWLs0pDajJiJK/dtVPpFx1utw/CzzLfmmtkagw==",
-      "requires": {
-        "email-addresses": "^4.0.0"
-      }
-    },
     "agent-base": {
       "version": "6.0.2",
       "resolved": "https://registry.npmjs.org/agent-base/-/agent-base-6.0.2.tgz",
@@ -13261,11 +13253,6 @@
         }
       }
     },
-    "email-addresses": {
-      "version": "4.0.0",
-      "resolved": "https://registry.npmjs.org/email-addresses/-/email-addresses-4.0.0.tgz",
-      "integrity": "sha512-Nas3sSSiD5lSIoqBos0FMjB9h4clHxXuAahHKGJ5doRWavEB7pBHzOxnI7R5f1MuGNrrSnsZFJ81HCBv0DZmnw=="
-    },
     "emittery": {
       "version": "0.8.1",
       "resolved": "https://registry.npmjs.org/emittery/-/emittery-0.8.1.tgz",
diff --git a/package.json b/package.json
index e19a74360..7be375805 100644
--- a/package.json
+++ b/package.json
@@ -69,7 +69,6 @@
     "@meetfranz/theme": "file:packages/theme",
     "@meetfranz/ui": "file:packages/ui",
     "@sentry/electron": "2.5.1",
-    "address-rfc2822": "2.1.0",
     "atob": "2.1.2",
     "auto-launch": "5.0.5",
     "btoa": "1.2.1",
diff --git a/recipes b/recipes
-Subproject 97697e3d069972844b2912a93022f4a4904a40d
+Subproject 2fd678efd32725a881152af2b2ee5fa64f422de
diff --git a/src/features/communityRecipes/store.js b/src/features/communityRecipes/store.js
index b115a53e1..a3614dd11 100644
--- a/src/features/communityRecipes/store.js
+++ b/src/features/communityRecipes/store.js
@@ -19,6 +19,7 @@ export class CommunityRecipesStore extends FeatureStore {
     if (!this.stores) return [];
 
     return this.stores.recipePreviews.dev.map((r) => {
+      // TODO: Need to figure out if this is even necessary/used
       r.isDevRecipe = !!r.author.find((a) => a.email === this.stores.user.data.email);
 
       return r;
diff --git a/src/models/Recipe.js b/src/models/Recipe.js
index 92ff0d67d..e616055d6 100644
--- a/src/models/Recipe.js
+++ b/src/models/Recipe.js
@@ -1,9 +1,9 @@
-import emailParser from 'address-rfc2822';
 import semver from 'semver';
 import { pathExistsSync } from 'fs-extra';
 import { join } from 'path';
 
 export default class Recipe {
+  // Note: Do NOT change these default values. If they change, then the corresponding changes in the recipes needs to be done
   id = '';
 
   name = '';
@@ -60,8 +60,6 @@ export default class Recipe {
 
     this.id = data.id || this.id;
     this.name = data.name || this.name;
-    this.rawAuthor = data.author || this.author;
-    this.description = data.description || this.description;
     this.version = data.version || this.version;
     this.path = data.path;
 
@@ -86,14 +84,8 @@ export default class Recipe {
     this.message = data.config.message || this.message;
   }
 
+  // TODO: Need to remove this if its not used anywhere
   get author() {
-    try {
-      const addresses = emailParser.parse(this.rawAuthor);
-      return addresses.map((a) => ({ email: a.address, name: a.phrase }));
-    } catch (err) {
-      console.warn(`Not a valid author for ${this.name}`);
-    }
-
     return [];
   }