diff options
author | Vijay Aravamudhan <vraravam@users.noreply.github.com> | 2021-12-08 23:44:20 +0530 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-12-08 23:44:20 +0530 |
commit | 40976eb2e6829587265ccc90c2159dd990bf8312 (patch) | |
tree | 046c0070964f245205bad1ad1c0d85bada28e41b | |
parent | chore: upgrade 'pnpm' to '6.23.6' (diff) | |
download | ferdium-app-40976eb2e6829587265ccc90c2159dd990bf8312.tar.gz ferdium-app-40976eb2e6829587265ccc90c2159dd990bf8312.tar.zst ferdium-app-40976eb2e6829587265ccc90c2159dd990bf8312.zip |
chore: use 'nativeWindowOpen' to see if this resolves issues with opening browser window on clicking links (#2308)
(based on https://github.com/TheGoddessInari/hamsket/commit/27226145f7ac0c5acf7aa13e6c8b26687b4e1013)
m--------- | recipes | 0 | ||||
-rw-r--r-- | src/components/services/content/ServiceWebview.js | 2 | ||||
-rw-r--r-- | src/index.ts | 5 |
3 files changed, 3 insertions, 4 deletions
diff --git a/recipes b/recipes | |||
Subproject a060508200794223adf50be6f7bc82e237033c6 | Subproject 1e1f9ecc53121749bc99a46bb5aecca51325836 | ||
diff --git a/src/components/services/content/ServiceWebview.js b/src/components/services/content/ServiceWebview.js index 713a0c21d..12aaf70b7 100644 --- a/src/components/services/content/ServiceWebview.js +++ b/src/components/services/content/ServiceWebview.js | |||
@@ -109,7 +109,7 @@ class ServiceWebview extends Component { | |||
109 | nodeintegration | 109 | nodeintegration |
110 | webpreferences={`spellcheck=${ | 110 | webpreferences={`spellcheck=${ |
111 | isSpellcheckerEnabled ? 1 : 0 | 111 | isSpellcheckerEnabled ? 1 : 0 |
112 | }, contextIsolation=1, enableRemoteModule=1`} | 112 | }, contextIsolation=1, nativeWindowOpen=1, enableRemoteModule=1`} |
113 | /> | 113 | /> |
114 | ); | 114 | ); |
115 | } | 115 | } |
diff --git a/src/index.ts b/src/index.ts index 4b21c6b2b..d46641fe1 100644 --- a/src/index.ts +++ b/src/index.ts | |||
@@ -213,6 +213,7 @@ const createWindow = () => { | |||
213 | contextIsolation: false, | 213 | contextIsolation: false, |
214 | webviewTag: true, | 214 | webviewTag: true, |
215 | preload: join(__dirname, 'sentry.js'), | 215 | preload: join(__dirname, 'sentry.js'), |
216 | nativeWindowOpen: true, | ||
216 | // @ts-expect-error Object literal may only specify known properties, and 'enableRemoteModule' does not exist in type 'WebPreferences'. | 217 | // @ts-expect-error Object literal may only specify known properties, and 'enableRemoteModule' does not exist in type 'WebPreferences'. |
217 | enableRemoteModule: true, | 218 | enableRemoteModule: true, |
218 | }, | 219 | }, |
@@ -519,9 +520,7 @@ ipcMain.on('open-browser-window', (_e, { url, serviceId }) => { | |||
519 | fullscreenable: false, | 520 | fullscreenable: false, |
520 | webPreferences: { | 521 | webPreferences: { |
521 | session: serviceSession, | 522 | session: serviceSession, |
522 | // TODO: Aren't these needed here? | 523 | nativeWindowOpen: true, |
523 | // contextIsolation: false, | ||
524 | // enableRemoteModule: true, | ||
525 | }, | 524 | }, |
526 | }); | 525 | }); |
527 | child.show(); | 526 | child.show(); |