diff options
author | 2022-06-21 08:20:29 +0530 | |
---|---|---|
committer | 2022-06-21 08:20:29 +0530 | |
commit | edf0b02c15aaa84e5b11a444ab3979ac4f05bf20 (patch) | |
tree | e0e35f0546bf961581e593cdfcc6efb49647aeb7 | |
parent | 6.0.0-nightly.70 [skip ci] (diff) | |
download | ferdium-app-edf0b02c15aaa84e5b11a444ab3979ac4f05bf20.tar.gz ferdium-app-edf0b02c15aaa84e5b11a444ab3979ac4f05bf20.tar.zst ferdium-app-edf0b02c15aaa84e5b11a444ab3979ac4f05bf20.zip |
Revert "Update build process to sign mac releases"
This reverts commit 7122309df14f4854e31c6b09bb915d319bcd0aaa.
The build is failing: https://github.com/ferdium/ferdium-app/runs/6976999014?check_suite_focus=true#step:15:57
-rw-r--r-- | .github/workflows/builds.yml | 20 | ||||
-rw-r--r-- | build-helpers/notarize.js | 2 | ||||
-rw-r--r-- | electron-builder.yml | 4 |
3 files changed, 15 insertions, 11 deletions
diff --git a/.github/workflows/builds.yml b/.github/workflows/builds.yml index c1e7b162b..7af56cb51 100644 --- a/.github/workflows/builds.yml +++ b/.github/workflows/builds.yml | |||
@@ -171,21 +171,23 @@ jobs: | |||
171 | env: | 171 | env: |
172 | GH_TOKEN: ${{ secrets.FERDIUM_PUBLISH_TOKEN }} | 172 | GH_TOKEN: ${{ secrets.FERDIUM_PUBLISH_TOKEN }} |
173 | CSC_IDENTITY_AUTO_DISCOVERY: true | 173 | CSC_IDENTITY_AUTO_DISCOVERY: true |
174 | APPLEID: ${{ secrets.APPLEID }} | 174 | # TODO: Commented out the code signing process for now (so as to at least get unsigned nightlies available for testing) |
175 | APPLEID_PASSWORD: ${{ secrets.APPLEID_PASSWORD }} | 175 | # APPLEID: ${{ secrets.APPLEID }} |
176 | CSC_LINK: ${{ secrets.CSC_LINK }} | 176 | # APPLEID_PASSWORD: ${{ secrets.APPLEID_PASSWORD }} |
177 | CSC_KEY_PASSWORD: ${{ secrets.CSC_KEY_PASSWORD }} | 177 | # CSC_LINK: ${{ secrets.CSC_LINK }} |
178 | # CSC_KEY_PASSWORD: ${{ secrets.CSC_KEY_PASSWORD }} | ||
178 | - name: Build Ferdium with publish for 'release' branch | 179 | - name: Build Ferdium with publish for 'release' branch |
179 | if: ${{ env.GIT_BRANCH_NAME == 'release' }} | 180 | if: ${{ env.GIT_BRANCH_NAME == 'release' }} |
180 | run: npm run build -- --publish always | 181 | run: npm run build -- --publish always |
181 | shell: bash | 182 | shell: bash |
182 | env: | 183 | env: |
183 | GH_TOKEN: ${{ secrets.FERDIUM_PUBLISH_TOKEN }} | 184 | GH_TOKEN: ${{ secrets.FERDIUM_PUBLISH_TOKEN }} |
184 | CSC_IDENTITY_AUTO_DISCOVERY: true | 185 | CSC_IDENTITY_AUTO_DISCOVERY: false |
185 | APPLEID: ${{ secrets.APPLEID }} | 186 | # TODO: Commented out the code signing process for now (so as to at least get unsigned nightlies available for testing) |
186 | APPLEID_PASSWORD: ${{ secrets.APPLEID_PASSWORD }} | 187 | # APPLEID: ${{ secrets.APPLEID }} |
187 | CSC_LINK: ${{ secrets.CSC_LINK }} | 188 | # APPLEID_PASSWORD: ${{ secrets.APPLEID_PASSWORD }} |
188 | CSC_KEY_PASSWORD: ${{ secrets.CSC_KEY_PASSWORD }} | 189 | # CSC_LINK: ${{ secrets.CSC_LINK }} |
190 | # CSC_KEY_PASSWORD: ${{ secrets.CSC_KEY_PASSWORD }} | ||
189 | 191 | ||
190 | build_linux: | 192 | build_linux: |
191 | name: "ubuntu ${{ github.event.inputs.message }}" | 193 | name: "ubuntu ${{ github.event.inputs.message }}" |
diff --git a/build-helpers/notarize.js b/build-helpers/notarize.js index 21b1466e7..bbd81c7b6 100644 --- a/build-helpers/notarize.js +++ b/build-helpers/notarize.js | |||
@@ -12,7 +12,7 @@ exports.default = async function notarizing(context) { | |||
12 | await notarize({ | 12 | await notarize({ |
13 | appBundleId: 'org.ferdium.ferdium-app', | 13 | appBundleId: 'org.ferdium.ferdium-app', |
14 | appPath: `${appOutDir}/${appName}.app`, | 14 | appPath: `${appOutDir}/${appName}.app`, |
15 | ascProvider: '55E9FPJ93P', | 15 | ascProvider: 'B6J9X9DWFL', |
16 | appleId: process.env.APPLEID, | 16 | appleId: process.env.APPLEID, |
17 | appleIdPassword: process.env.APPLEID_PASSWORD, | 17 | appleIdPassword: process.env.APPLEID_PASSWORD, |
18 | }); | 18 | }); |
diff --git a/electron-builder.yml b/electron-builder.yml index d864a1848..142d3e2c3 100644 --- a/electron-builder.yml +++ b/electron-builder.yml | |||
@@ -26,7 +26,9 @@ dmg: | |||
26 | { x: 122, y: 240, type: file }, | 26 | { x: 122, y: 240, type: file }, |
27 | ] | 27 | ] |
28 | 28 | ||
29 | afterSign: ./build-helpers/notarize.js | 29 | # TODO: When we have a registered developer account we need to uncomment this line so that the signing process can occur but without the notarization. |
30 | # This is the notarization which would allow to have the DMG analysed so that it can be opened straight away after download. | ||
31 | # afterSign: ./build-helpers/notarize.js | ||
30 | 32 | ||
31 | protocols: | 33 | protocols: |
32 | name: Ferdium | 34 | name: Ferdium |