Delete service confirmation (#1328)

3 files changed, 33 insertions, 3 deletions

diff --git a/src/components/services/tabs/TabItem.js b/src/components/services/tabs/TabItem.js
index 479f151a6..75611f77c 100644
--- a/src/components/services/tabs/TabItem.js
+++ b/src/components/services/tabs/TabItem.js
@@ -14,7 +14,7 @@ import { ctrlKey, cmdKey } from '../../../environment';
 
 const IS_SERVICE_DEBUGGING_ENABLED = (localStorage.getItem('debug') || '').includes('Franz:Service');
 
-const { Menu } = remote;
+const { Menu, dialog, app } = remote;
 
 const messages = defineMessages({
   reload: {
@@ -53,6 +53,10 @@ const messages = defineMessages({
     id: 'tabs.item.deleteService',
     defaultMessage: '!!!Delete Service',
   },
+  confirmDeleteService: {
+    id: 'tabs.item.confirmDeleteService',
+    defaultMessage: '!!!Do you really want to delete the {serviceName} service?',
+  },
 });
 
 const styles = {
@@ -147,7 +151,6 @@ const styles = {
     } = this.props;
     const { intl } = this.context;
 
-
     const menuTemplate = [{
       label: service.name || service.recipe.name,
       enabled: false,
@@ -181,7 +184,20 @@ const styles = {
       type: 'separator',
     }, {
       label: intl.formatMessage(messages.deleteService),
-      click: () => deleteService(),
+      click: () => {
+        const selection = dialog.showMessageBoxSync(app.mainWindow, {
+          type: 'question',
+          message: intl.formatMessage(messages.deleteService),
+          detail: intl.formatMessage(messages.confirmDeleteService, { serviceName: service.name || service.recipe.name }),
+          buttons: [
+            'Yes',
+            'No',
+          ],
+        });
+        if (selection === 0) {
+          deleteService();
+        }
+      },
     }];
     const menu = Menu.buildFromTemplate(menuTemplate);
 
diff --git a/src/i18n/locales/en-US.json b/src/i18n/locales/en-US.json
index a2ed91b79..bb15485d1 100644
--- a/src/i18n/locales/en-US.json
+++ b/src/i18n/locales/en-US.json
@@ -519,6 +519,7 @@
   "subscription.teaser.intro": "Ferdi 5 comes with a wide range of new features to boost up your everyday communication - batteries included. Check out our new plans and find out which one suits you most!",
   "subscriptionPopup.buttonCancel": "Cancel",
   "subscriptionPopup.buttonDone": "Done",
+  "tabs.item.confirmDeleteService": "Do you really want to delete the {serviceName} service?",
   "tabs.item.deleteService": "Delete service",
   "tabs.item.disableAudio": "Disable audio",
   "tabs.item.disableNotifications": "Disable notifications",
diff --git a/src/i18n/messages/src/components/services/tabs/TabItem.json b/src/i18n/messages/src/components/services/tabs/TabItem.json
index 495d35c8b..a1b0d2435 100644
--- a/src/i18n/messages/src/components/services/tabs/TabItem.json
+++ b/src/i18n/messages/src/components/services/tabs/TabItem.json
@@ -115,5 +115,18 @@
       "line": 55,
       "column": 3
     }
+  },
+  {
+    "id": "tabs.item.confirmDeleteService",
+    "defaultMessage": "!!!Do you really want to delete the {serviceName} service?",
+    "file": "src/components/services/tabs/TabItem.js",
+    "start": {
+      "line": 56,
+      "column": 24
+    },
+    "end": {
+      "line": 59,
+      "column": 3
+    }
   }
 ]
\ No newline at end of file