diff options
author | Vijay Aravamudhan <vraravam@users.noreply.github.com> | 2024-03-28 10:12:05 +0000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-03-28 15:42:05 +0530 |
commit | 53c72ea5ac4f103291fdd347b7cd9cc0dbafa4b5 (patch) | |
tree | b5317730f7e7ac879732c1557a53ef4515a654e4 /.github | |
parent | Upgrade electron to '29.1.6' (diff) | |
download | ferdium-app-53c72ea5ac4f103291fdd347b7cd9cc0dbafa4b5.tar.gz ferdium-app-53c72ea5ac4f103291fdd347b7cd9cc0dbafa4b5.tar.zst ferdium-app-53c72ea5ac4f103291fdd347b7cd9cc0dbafa4b5.zip |
Bring in missing python (system dependency) (#1639)
* Introduce python as a system dependency (needed by node-gyp to compile native modules)
* Introduce node-pre-gyp as a dependency
* Upgrade sqlite3 to 5.1.7 to test the above
Note: Currently this still depends on the availability of prebuilt binaries from the prebuild library. Which means that once a new version is available, only then will we know if this python/node-gyp integration works or whether it will still fallback to the availability of the prebuilt binaries from external sources. Only time will tell if we have solved the issue or not.
Diffstat (limited to '.github')
-rw-r--r-- | .github/workflows/builds.yml | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/.github/workflows/builds.yml b/.github/workflows/builds.yml index 6ad31da9e..1788e42d9 100644 --- a/.github/workflows/builds.yml +++ b/.github/workflows/builds.yml | |||
@@ -55,6 +55,9 @@ jobs: | |||
55 | with: | 55 | with: |
56 | node-version-file: '.nvmrc' | 56 | node-version-file: '.nvmrc' |
57 | cache: 'pnpm' | 57 | cache: 'pnpm' |
58 | - name: Use python specified in the '.python-version' file | ||
59 | uses: actions/setup-python@v5 | ||
60 | if: ${{ github.event_name == 'schedule' || (github.event_name == 'workflow_dispatch' && contains(github.event.inputs.message, '[nightly branch]')) }} | ||
58 | - name: Install node dependencies | 61 | - name: Install node dependencies |
59 | if: ${{ github.event_name == 'schedule' || (github.event_name == 'workflow_dispatch' && contains(github.event.inputs.message, '[nightly branch]')) }} | 62 | if: ${{ github.event_name == 'schedule' || (github.event_name == 'workflow_dispatch' && contains(github.event.inputs.message, '[nightly branch]')) }} |
60 | uses: nick-fields/retry@v3 | 63 | uses: nick-fields/retry@v3 |
@@ -177,6 +180,8 @@ jobs: | |||
177 | with: | 180 | with: |
178 | node-version-file: '.nvmrc' | 181 | node-version-file: '.nvmrc' |
179 | cache: 'pnpm' | 182 | cache: 'pnpm' |
183 | - name: Use python specified in the '.python-version' file | ||
184 | uses: actions/setup-python@v5 | ||
180 | - name: Install node dependencies | 185 | - name: Install node dependencies |
181 | uses: nick-fields/retry@v3 | 186 | uses: nick-fields/retry@v3 |
182 | with: | 187 | with: |
@@ -256,6 +261,8 @@ jobs: | |||
256 | with: | 261 | with: |
257 | node-version-file: '.nvmrc' | 262 | node-version-file: '.nvmrc' |
258 | cache: 'pnpm' | 263 | cache: 'pnpm' |
264 | - name: Use python specified in the '.python-version' file | ||
265 | uses: actions/setup-python@v5 | ||
259 | - name: Install node dependencies | 266 | - name: Install node dependencies |
260 | uses: nick-fields/retry@v3 | 267 | uses: nick-fields/retry@v3 |
261 | with: | 268 | with: |
@@ -356,6 +363,8 @@ jobs: | |||
356 | with: | 363 | with: |
357 | node-version-file: '.nvmrc' | 364 | node-version-file: '.nvmrc' |
358 | cache: 'pnpm' | 365 | cache: 'pnpm' |
366 | - name: Use python specified in the '.python-version' file | ||
367 | uses: actions/setup-python@v5 | ||
359 | #TODO - Remove this once https://github.com/electron-userland/electron-builder/issues/6933#issuecomment-1213438889 is resolved | 368 | #TODO - Remove this once https://github.com/electron-userland/electron-builder/issues/6933#issuecomment-1213438889 is resolved |
360 | - name: Tweak pnpm.cjs | 369 | - name: Tweak pnpm.cjs |
361 | run: | | 370 | run: | |