ci: update various github actions to latest (#1494)

- update `actions/checkout` from v3 to v4
- update `actions/setup-node` from v3 to v4
- change `nick-fields/retry` from v2.8.3 to v2
- update `bluwy/release-for-reddit-action` from v1.2.0 to v2
- lock all CI runners to fixed version rather than latest

5 files changed, 88 insertions, 89 deletions

diff --git a/.github/workflows/builds.yml b/.github/workflows/builds.yml
index 8e5f6c9bf..bb0984368 100644
--- a/.github/workflows/builds.yml
+++ b/.github/workflows/builds.yml
@@ -40,7 +40,7 @@ jobs:
       should_run: ${{ steps.should_run.outputs.should_run }}
     steps:
       - name: Checkout code along with submodules for the 'nightly' branch if the trigger event is 'scheduled'
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         if: ${{ github.event_name == 'schedule' || (github.event_name == 'workflow_dispatch' && contains(github.event.inputs.message, '[nightly branch]')) }}
         with:
           ref: nightly
@@ -50,14 +50,14 @@ jobs:
         uses: pnpm/action-setup@v2
         if: ${{ github.event_name == 'schedule' || (github.event_name == 'workflow_dispatch' && contains(github.event.inputs.message, '[nightly branch]')) }}
       - name: Use Node.js specified in the '.nvmrc' file
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         if: ${{ github.event_name == 'schedule' || (github.event_name == 'workflow_dispatch' && contains(github.event.inputs.message, '[nightly branch]')) }}
         with:
           node-version-file: '.nvmrc'
           cache: 'pnpm'
       - name: Install node dependencies
         if: ${{ github.event_name == 'schedule' || (github.event_name == 'workflow_dispatch' && contains(github.event.inputs.message, '[nightly branch]')) }}
-        uses: nick-fields/retry@v2.8.3
+        uses: nick-fields/retry@v2
         with:
           command: pnpm i
           timeout_minutes: 15
@@ -141,14 +141,14 @@ jobs:
           echo "ELECTRON_BUILDER_CACHE=$HOME/.cache/electron-builder" >> $GITHUB_ENV
           echo "MANUAL_REBUILD_ON_NIGHTLY=${{ github.event_name == 'workflow_dispatch' && contains(github.event.inputs.message, '[nightly branch]') }}" >> $GITHUB_ENV
       - name: Checkout code along with submodules for the 'nightly' branch if the trigger event is 'scheduled' or this is a forced rebuild on the nightly branch
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         if: ${{ github.event_name == 'schedule' || env.MANUAL_REBUILD_ON_NIGHTLY == 'true' }}
         with:
           submodules: recursive
           fetch-depth: 0 # Note: Needed to be able to pull the 'develop' branch as well for merging
           ref: nightly
       - name: Checkout code along with submodules for any branch if the trigger event is NOT 'scheduled' and this is NOT a forced rebuild on the nightly branch
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         if: ${{ github.event_name != 'schedule' && env.MANUAL_REBUILD_ON_NIGHTLY != 'true' }}
         with:
           submodules: recursive
@@ -173,12 +173,12 @@ jobs:
       - name: Install pnpm
         uses: pnpm/action-setup@v2
       - name: Use Node.js specified in the '.nvmrc' file
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version-file: '.nvmrc'
           cache: 'pnpm'
       - name: Install node dependencies
-        uses: nick-fields/retry@v2.8.3
+        uses: nick-fields/retry@v2
         with:
           command: pnpm i
           timeout_minutes: 15
@@ -220,14 +220,14 @@ jobs:
           echo "ELECTRON_BUILDER_CACHE=$HOME/.cache/electron-builder" >> $GITHUB_ENV
           echo "MANUAL_REBUILD_ON_NIGHTLY=${{ github.event_name == 'workflow_dispatch' && contains(github.event.inputs.message, '[nightly branch]') }}" >> $GITHUB_ENV
       - name: Checkout code along with submodules for the 'nightly' branch if the trigger event is 'scheduled' or this is a forced rebuild on the nightly branch
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         if: ${{ github.event_name == 'schedule' || env.MANUAL_REBUILD_ON_NIGHTLY == 'true' }}
         with:
           submodules: recursive
           fetch-depth: 0 # Note: Needed to be able to pull the 'develop' branch as well for merging
           ref: nightly
       - name: Checkout code along with submodules for any branch if the trigger event is NOT 'scheduled' and this is NOT a forced rebuild on the nightly branch
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         if: ${{ github.event_name != 'schedule' && env.MANUAL_REBUILD_ON_NIGHTLY != 'true' }}
         with:
           submodules: recursive
@@ -252,12 +252,12 @@ jobs:
       - name: Install pnpm
         uses: pnpm/action-setup@v2
       - name: Use Node.js specified in the '.nvmrc' file
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version-file: '.nvmrc'
           cache: 'pnpm'
       - name: Install node dependencies
-        uses: nick-fields/retry@v2.8.3
+        uses: nick-fields/retry@v2
         with:
           command: pnpm i
           timeout_minutes: 15
@@ -320,14 +320,14 @@ jobs:
           echo "MANUAL_REBUILD_ON_NIGHTLY=${{ github.event_name == 'workflow_dispatch' && contains(github.event.inputs.message, '[nightly branch]') }}" >> $GITHUB_ENV
         shell: bash
       - name: Checkout code along with submodules for the 'nightly' branch if the trigger event is 'scheduled' or this is a forced rebuild on the nightly branch
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         if: ${{ github.event_name == 'schedule' || env.MANUAL_REBUILD_ON_NIGHTLY == 'true' }}
         with:
           submodules: recursive
           fetch-depth: 0 # Note: Needed to be able to pull the 'develop' branch as well for merging
           ref: nightly
       - name: Checkout code along with submodules for any branch if the trigger event is NOT 'scheduled' and this is NOT a forced rebuild on the nightly branch
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         if: ${{ github.event_name != 'schedule' && env.MANUAL_REBUILD_ON_NIGHTLY != 'true' }}
         with:
           submodules: recursive
@@ -352,7 +352,7 @@ jobs:
       - name: Install pnpm
         uses: pnpm/action-setup@v2
       - name: Use Node.js specified in the '.nvmrc' file
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version-file: '.nvmrc'
           cache: 'pnpm'
@@ -365,7 +365,7 @@ jobs:
           sed -i 's/\/usr\/bin\/env node/node/g' "$PNPM_BASEDIR/pnpm/bin/pnpm.cjs"
         shell: bash
       - name: Install node dependencies
-        uses: nick-fields/retry@v2.8.3
+        uses: nick-fields/retry@v2
         with:
           command: pnpm i
           timeout_minutes: 15
diff --git a/.github/workflows/homebrew-cask-updates.yml b/.github/workflows/homebrew-cask-updates.yml
index eaecc0b2c..0d70868dd 100644
--- a/.github/workflows/homebrew-cask-updates.yml
+++ b/.github/workflows/homebrew-cask-updates.yml
@@ -8,41 +8,41 @@ on:
 
 jobs:
   bump-casks:
-    runs-on: macos-latest
+    runs-on: macos-12
     steps:
-    - name: Publish nightly
-      uses: macauley/action-homebrew-bump-cask@v1
-      if: ${{ contains(github.event.release.tag_name, 'nightly') }}
-      with:
-        # Required, custom GitHub access token with only the 'public_repo' scope enabled
-        token: ${{ secrets.HOMEBREW_FERDIUM_PUBLISH_TOKEN }}
-        # Bump all outdated casks in this tap
-        tap: ferdium/homebrew-ferdium
-        # Bump only these casks if outdated
-        cask: ferdium-nightly
-        livecheck: true
-        dryrun: false
-    - name: Publish beta
-      uses: macauley/action-homebrew-bump-cask@v1
-      if: ${{ contains(github.event.release.tag_name, 'beta') }}
-      with:
-        # Required, custom GitHub access token with only the 'public_repo' scope enabled
-        token: ${{ secrets.HOMEBREW_FERDIUM_PUBLISH_TOKEN }}
-        # Bump all outdated casks in this tap
-        tap: ferdium/homebrew-ferdium
-        # Bump only these casks if outdated
-        cask: ferdium-beta
-        livecheck: true
-        dryrun: false
-    - name: Publish release
-      uses: macauley/action-homebrew-bump-cask@v1
-      if: ${{ !contains(github.event.release.tag_name, 'nightly') && !contains(github.event.release.tag_name, 'beta') }}
-      with:
-        # Required, custom GitHub access token with only the 'public_repo' scope enabled
-        token: ${{ secrets.HOMEBREW_FERDIUM_PUBLISH_TOKEN }}
-        # Bump all outdated casks in this tap
-        tap: ferdium/homebrew-ferdium
-        # Bump only these casks if outdated
-        cask: ferdium
-        livecheck: true
-        dryrun: false
+      - name: Publish nightly
+        uses: macauley/action-homebrew-bump-cask@v1
+        if: ${{ contains(github.event.release.tag_name, 'nightly') }}
+        with:
+          # Required, custom GitHub access token with only the 'public_repo' scope enabled
+          token: ${{ secrets.HOMEBREW_FERDIUM_PUBLISH_TOKEN }}
+          # Bump all outdated casks in this tap
+          tap: ferdium/homebrew-ferdium
+          # Bump only these casks if outdated
+          cask: ferdium-nightly
+          livecheck: true
+          dryrun: false
+      - name: Publish beta
+        uses: macauley/action-homebrew-bump-cask@v1
+        if: ${{ contains(github.event.release.tag_name, 'beta') }}
+        with:
+          # Required, custom GitHub access token with only the 'public_repo' scope enabled
+          token: ${{ secrets.HOMEBREW_FERDIUM_PUBLISH_TOKEN }}
+          # Bump all outdated casks in this tap
+          tap: ferdium/homebrew-ferdium
+          # Bump only these casks if outdated
+          cask: ferdium-beta
+          livecheck: true
+          dryrun: false
+      - name: Publish release
+        uses: macauley/action-homebrew-bump-cask@v1
+        if: ${{ !contains(github.event.release.tag_name, 'nightly') && !contains(github.event.release.tag_name, 'beta') }}
+        with:
+          # Required, custom GitHub access token with only the 'public_repo' scope enabled
+          token: ${{ secrets.HOMEBREW_FERDIUM_PUBLISH_TOKEN }}
+          # Bump all outdated casks in this tap
+          tap: ferdium/homebrew-ferdium
+          # Bump only these casks if outdated
+          cask: ferdium
+          livecheck: true
+          dryrun: false
diff --git a/.github/workflows/reddit.yml b/.github/workflows/reddit.yml
index 79149c405..77c771030 100644
--- a/.github/workflows/reddit.yml
+++ b/.github/workflows/reddit.yml
@@ -6,17 +6,17 @@ on:
 
 jobs:
   test:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - name: Release for Reddit
-        uses: bluwy/release-for-reddit-action@v1.2.0
+        uses: bluwy/release-for-reddit-action@v2
         with:
           username: ${{ secrets.REDDIT_USERNAME }}
           password: ${{ secrets.REDDIT_PASSWORD }}
           app-id: ${{ secrets.REDDIT_APP_ID }}
           app-secret: ${{ secrets.REDDIT_APP_SECRET }}
           subreddit: ferdium # Submit to /r/ferdium
-          title: "[Release] Ferdium ${{ github.event.release.tag_name }}"
+          title: '[Release] Ferdium ${{ github.event.release.tag_name }}'
           # flair-id: "7aa4f288-bf0d-11ec-a939-8e36666e1f23"
-          comment: "${{ github.event.release.body }}"
+          comment: '${{ github.event.release.body }}'
           notification: true
diff --git a/.github/workflows/tag-repos.yml b/.github/workflows/tag-repos.yml
index 6ef055e7b..0e5de76a5 100644
--- a/.github/workflows/tag-repos.yml
+++ b/.github/workflows/tag-repos.yml
@@ -8,27 +8,27 @@ on:
 
 jobs:
   tag-repos:
-    runs-on: macos-latest
+    runs-on: macos-12
     steps:
-    - name: Checkout code along with submodules for the 'nightly' branch if the trigger event is 'release'
-      uses: actions/checkout@v3
-      if: ${{ contains(github.event.release.tag_name, 'nightly') || (github.event_name == 'workflow_dispatch') }}
-      with:
-        ref: nightly
-        submodules: recursive
-        fetch-depth: 0 # Note: Needed to be able to pull the 'develop' branch as well for merging
-    - name: Checkout code along with submodules for the 'release' branch if the trigger event is 'release'
-      uses: actions/checkout@v3
-      if: ${{ !contains(github.event.release.tag_name, 'nightly') }}
-      with:
-        ref: release
-        submodules: recursive
-        fetch-depth: 0 # Note: Needed to be able to pull the 'develop' branch as well for merging
-    - name: Extract Git tag name from the currently checked out branch (not from the branch where this run was kicked off)
-      run: |
-        TAG_NAME=$(node -p 'require("./package.json").version')
-        echo "TAG_NAME=v$TAG_NAME" >> $GITHUB_ENV
-      shell: bash
+      - name: Checkout code along with submodules for the 'nightly' branch if the trigger event is 'release'
+        uses: actions/checkout@v4
+        if: ${{ contains(github.event.release.tag_name, 'nightly') || (github.event_name == 'workflow_dispatch') }}
+        with:
+          ref: nightly
+          submodules: recursive
+          fetch-depth: 0 # Note: Needed to be able to pull the 'develop' branch as well for merging
+      - name: Checkout code along with submodules for the 'release' branch if the trigger event is 'release'
+        uses: actions/checkout@v4
+        if: ${{ !contains(github.event.release.tag_name, 'nightly') }}
+        with:
+          ref: release
+          submodules: recursive
+          fetch-depth: 0 # Note: Needed to be able to pull the 'develop' branch as well for merging
+      - name: Extract Git tag name from the currently checked out branch (not from the branch where this run was kicked off)
+        run: |
+          TAG_NAME=$(node -p 'require("./package.json").version')
+          echo "TAG_NAME=v$TAG_NAME" >> $GITHUB_ENV
+        shell: bash
     # Note: commented out the tagging of the main repo - since that is auto-created when a new release is published
     # - name: Tag the main repo
     #   run: |
diff --git a/.github/workflows/winget-bucket-update.yml b/.github/workflows/winget-bucket-update.yml
index 1013a8921..84886b46a 100644
--- a/.github/workflows/winget-bucket-update.yml
+++ b/.github/workflows/winget-bucket-update.yml
@@ -9,7 +9,7 @@ on:
   workflow_dispatch:
     inputs:
       message:
-        description: "Channel to update"
+        description: 'Channel to update'
         required: false
   release:
     types: [published]
@@ -19,13 +19,13 @@ env:
 
 jobs:
   manual_winget_update:
-    runs-on: windows-latest
-    name: "Manual winget update: ${{ github.event.inputs.message }}"
+    runs-on: windows-2022
+    name: 'Manual winget update: ${{ github.event.inputs.message }}'
     if: ${{ github.event_name == 'workflow_dispatch' }}
     steps:
-      - name: "Install winget"
-      # cf https://github.com/actions/virtual-environments/issues/910#issuecomment-1009640391
-      # TODO: update urls to get more updated version
+      - name: 'Install winget'
+        # cf https://github.com/actions/virtual-environments/issues/910#issuecomment-1009640391
+        # TODO: update urls to get more updated version
         run: |
           $ErrorActionPreference = 'Stop'
 
@@ -35,10 +35,10 @@ jobs:
           iwr 'https://github.com/microsoft/winget-cli/releases/download/v1.1.12653/9c0fe2ce7f8e410eb4a8f417de74517e_License1.xml' -Outfile $env:TEMP\winget.license
 
           Add-AppxProvisionedPackage -Online -PackagePath $env:TEMP\winget.msixbundle -LicensePath $env:TEMP\winget.license -DependencyPackagePath @("$env:TEMP\vclibs.appx", "$env:TEMP\vclibsuwp.appx")
-      - name: "Verify winget"
+      - name: 'Verify winget'
         run: |
           winget --info
-      - name: "Get release tag"
+      - name: 'Get release tag'
         run: |
           if ("${{ contains(github.event.inputs.message, '[nightly]') }}" -eq $True) {
             $preRel = $True
@@ -64,7 +64,7 @@ jobs:
           echo "last_version=$lastVersion" | Out-File -FilePath $Env:GITHUB_ENV -Encoding utf8 -Append
           echo "PACKAGE_NAME=$package" | Out-File -FilePath $Env:GITHUB_ENV -Encoding utf8 -Append
 
-      - name: "Verify if version already exist on winget"
+      - name: 'Verify if version already exist on winget'
         run: |
           $lastVersion = '${{ env.last_version }}'
           $versions = winget show --id '${{ env.PACKAGE_NAME }}' --versions --accept-source-agreements
@@ -73,7 +73,7 @@ jobs:
             echo "version_exists=true" | Out-File -FilePath $Env:GITHUB_ENV -Encoding utf8 -Append
           }
 
-      - name: "Publish update"
+      - name: 'Publish update'
         if: ${{ env.version_exists != 'true' }}
         run: |
           $release=Invoke-RestMethod -Uri '${{ env.REPO_URL }}'
@@ -95,11 +95,10 @@ jobs:
           Write-Host $command
           Invoke-Expression $command
 
-
   winget_release:
-    name: "Update winget after publish: ${{ github.event.inputs.message }}"
+    name: 'Update winget after publish: ${{ github.event.inputs.message }}'
     if: ${{ github.event_name == 'release' }}
-    runs-on: windows-latest
+    runs-on: windows-2022
     steps:
       - name: Check release type
         run: |